Issue 67969 - key release event in gtk vcl plugin
Summary: key release event in gtk vcl plugin
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.4
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-31 07:48 UTC by ekato
Modified: 2006-08-07 10:36 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch against gtkframe.cxx r1.47.40.3 (808 bytes, patch)
2006-07-31 07:50 UTC, ekato 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ekato 2006-07-31 07:48:17 UTC 
In OOo's gtk plugin, only key press event is filtered for gtk_im_context.  Some
input methods need explicit key release event corresponding to key press in
order to behave properly (such as uim-prime).  In gtk+,
gtk_im_context_filter_keypress() is used for key release event too (see
http://developer.gnome.org/doc/API/2.0/gtk/GtkIMContext.html#gtk-im-context-filter-keypress),
and all of normal gtk+ widget filter both key press and release event in its IM
context.

So please apply the attached patch.  I've already signed to JCA.

Cheers,
-- 
Etsushi Kato
Comment 1 ekato 2006-07-31 07:50:14 UTC 
Created attachment 38138 [details]
Patch against gtkframe.cxx r1.47.40.3
Comment 2 philipp.lohmann 2006-07-31 09:49:32 UTC 
Good that they changed their mind. I found it unreasonable to only pass
keypresss in the first place.
Comment 3 philipp.lohmann 2006-07-31 09:50:44 UTC 
Do you happen to know when this change made it into gtk ? I'd want to have the
old behaviour for older gtk versions.
Comment 4 ekato 2006-07-31 10:23:15 UTC 
I just checked gtk+-2.0.0, and found gtkentry and gtktextview do filter the key
release event using gtk_im_context_filter_keypress().  So they seems to filter
key release event since long time ago, but they didn't document explicitly.

For the document, I requested them to update last year in 
http://bugzilla.gnome.org/show_bug.cgi?id=324996, and they are included in
gtk+-2.8.10.
Comment 5 philipp.lohmann 2006-07-31 10:37:48 UTC 
OK, then we don't need a version check. Thank you for looking into this.
Comment 6 philipp.lohmann 2006-07-31 14:24:51 UTC 
committed in CWS vcl64
Comment 7 philipp.lohmann 2006-08-02 14:14:39 UTC 
verified in CWS vcl64
Comment 8 philipp.lohmann 2006-08-07 10:36:26 UTC 
seen in m181