Apache OpenOffice (AOO) Bugzilla – Issue 67111
Warnings: GNU/Linux SPARC sal
Last modified: 2007-10-07 22:41:39 UTC
On GNU/Linux SPARC m173 After a patch like issue 66807, the next problem is here: ccache /usr/local/4.1/bin/gcc -m32 -fmessage-length=0 -c -I. -I../../unxlngs.pro/inc/cpposl -I../inc -I../../inc -I../../unx/inc -I../../unxlngs.pro/inc -I. -I/home/jim/vanilla/solver/680/unxlngs.pro/inc/dont_use_stl -I/home/jim/vanilla/solver/680/unxlngs.pro/inc/external -I/home/jim/vanilla/solver/680/unxlngs.pro/inc -I/home/jim/vanilla/solenv/unxlngs/inc -I/home/jim/vanilla/solenv/inc -I/home/jim/vanilla/res -I/home/jim/vanilla/solver/680/unxlngs.pro/inc/dont_use_stl -I/home/jim/vanilla/solenv/inc/Xp31 -I/usr/local/4.1/include -I/usr/include -I/home/jim/vanilla/solver/680/unxlngs.pro/inc/offuh -I. -I../../res -I. -Os -fno-strict-aliasing -DENABLE_CRASH_REPORT -pipe -g1 -Wall -Wextra -Wendif-labels -Werror -DLINUX -DUNX -DVCL -DGCC -DC300 -DSPARC -DCVER=C300 -DGLIBC=2 -D_PTHREADS -D_REENTRANT -DSPARC -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -DHAVE_GCC_VISIBILITY_FEATURE -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DGXX_INCLUDE_PATH=/usr/local/4.1/lib/gcc/sparc-unknown-linux-gnu/4.1.2/../../../../include/c++/4.1.2 -DSUPD=680 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_OFF -DCUI -DSOLAR_JAVA -DSRC680=SRC680 -DMULTITHREAD -o ../../unxlngs.pro/obj/backtrace.o backtrace.c cc1: warnings being treated as errors backtrace.c: In function 'backtrace': backtrace.c:265: warning: argument 'buffer' might be clobbered by 'longjmp' or 'vfork' dmake: Error code 1, while making '../../unxlngs.pro/obj/backtrace.obj' '---* tg_merge.mk *---' jim@sun:~/vanilla/sal/osl/unx$
Created attachment 37560 [details] workaround - turn off optimisation
reassign
New patch to be attached will remove warnings in backtrace.c, the best way is to remove copy/pasted code and share the existing solaris code which is already warning-free. Years ago I did copy/paste that code because I had no idea and did not dare touch it. This will need QA by solaris team. Perhaps this method can be adapted to include other platforms? Also the NOOPTFILES is needed for gcc4.1.2
Created attachment 40319 [details] remove copy/paste, and add NOOPTFILES
correction to sal.patch, should be SLO not OBJ (to be confirmed) +NOOPTFILES=$(SLO)$/backtrace.obj
In sal module files are stored in both outdir/obj *and* outdir/slo. In which case both are needed in NOOPTFILES. This will not always be obvious if the module is already part-built. Revised patch is attached.
Created attachment 40347 [details] revised sal patch
backtrace.c cleanup is ready for GNU/Linux SPARC. Revised patch attached.
set target. planning to commit in unxlngs06
Created attachment 40887 [details] cleanup backtrace.c
@mh: can you advise please - who should review this patch? I have removed some copy/pasted code from GNU/Linux SPARC and instead use the solaris backtrace code with some minor changes.
reassign for review
mhu->sparcmoz: latest patch (id 40887) reviewed; looks okay in general. Just a minor nit: #include <malloc.h> looks somewhat strange, probably <stddef.h> should be what is needed here (ptrdiff_t). Anyway, patch approved; please include into a cws of your choice.
@sparcmoz: Can this issue be completed and closed? James McKenzie
Not completed yet. I am working on some related patches and will commit all into a cws soon.
new target
Investigations show the Linux/SPARC backtrace code is no longer required. This code can be removed and use common Linux code instead. This is not urgent, whoever likes to do it will make a new issue.
Change of plans - remove SPARC/Linux backtrace code and use common linux code instead.
closed