Issue 66717 - m173-to-be: W32 build fails in berkeleydb
Summary: m173-to-be: W32 build fails in berkeleydb
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: PC Windows, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.0.4
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 66757
  Show dependency tree
 
Reported: 2006-06-24 15:24 UTC by quetschke
Modified: 2006-09-05 14:37 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
cmd file for mut_win32.c (933 bytes, patch)
2006-06-27 04:12 UTC, quetschke
no flags Details | Diff
Reference cmd file (1.32 KB, patch)
2006-06-27 04:12 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-06-24 15:24:28 UTC
The build fails with:

------------------------------
Making: ../../../../../wntmsci10.pro/slo/mut_win32.obj
guw.pl /cygdrive/c/MSVS2003/Vc7/bin/cl.exe @/tmp/mkIkY1sz
cl : Command line warning D4025 : overriding '/Ox' with '/Od'
mut_win32.c
d:\w1\tin_tcsh\berkeleydb\wntmsci10.pro\misc\build\db-4.2.52.NC\build_win32\win_db.h(33)
: fatal error C1083: Cannot open include file: 'windows.h': No such file or
directory
dmake:  Error code 2, while making '../../../../../wntmsci10.pro/slo/mut_win32.obj'
---* tg_merge.mk *---
dmake:  Error code 255, while making 'mutex'
---* tg_merge.mk *---
dmake:  Error code 255, while making
'./wntmsci10.pro/misc/build/so_built_so_berkeleydb'

ERROR: Error 65280 occurred while making /cygdrive/d/w1/tin_tcsh/berkeleydb
---* tg_merge.mk *---

Tinderbox log:
<http://go-oo.org/tinderbox/gunzip.cgi?tree=SRC680_m173&brief-log=1151122182.13714#err4>

The module also shows lots of missing macro warnings that were not there before.
Comment 1 quetschke 2006-06-24 22:01:54 UTC
This one fails because of:

target.mk revision 1.170.4.1
#i62048# add lines lost on itegration of ause051.

berkeleydb finishes with this patch:

+++ solenv/inc/target.mk        24 Jun 2006 20:49:34 -0000
@@ -59,8 +59,8 @@
 SOLARINC+=$(DB2INC)
 SOLARINC+=$(DAOINC)
 # make sure INCLUDE isn't set
-INCLUDE:=
-.EXPORT : INCLUDE

Somehow $(SOLARINC) doesn't make it completely into this external module.

Even with this patch there are lots of missing macro warnings.
Comment 2 jens-heiner.rechtien 2006-06-26 15:44:16 UTC
Reassign to hjs.
Comment 3 quetschke 2006-06-27 04:10:47 UTC
I reproduced the problem and caught the command file. Error:

cd mutex ; dmake subdmake=true -vrt 
echo ------------------------------
------------------------------
echo Making: ../../../../../wntmsci10.pro/slo/mut_win32.obj
Making: ../../../../../wntmsci10.pro/slo/mut_win32.obj
/bin/rm -f ../../../../../wntmsci10.pro/slo/mut_win32.obj >& /dev/null
guw.pl /cygdrive/c/MSVS2003/Vc7/bin/cl.exe @/tmp/mkalAynV
cl : Command line warning D4025 : overriding '/Ox' with '/Od'
mut_win32.c
d:\w1\tin_ws\berkeleydb\wntmsci10.pro\misc\build\db-4.2.52.NC\build_win32\win_db.h(33)
: fatal error C1083: Cannot open include file: 'windows.h': No such file or
directory
dmake:  Left temp file [/tmp/mkalAynV]
dmake:  Error code 2, while making '../../../../../wntmsci10.pro/slo/mut_win32.obj'
echo '---* tg_merge.mk *---'

The cmd file for mut_win32 follows as attachment. The next attachment is the
command file for crdel_auto.c as a reference for a file that works.
Comment 4 quetschke 2006-06-27 04:12:16 UTC
Created attachment 37339 [details]
cmd file for mut_win32.c
Comment 5 quetschke 2006-06-27 04:12:48 UTC
Created attachment 37340 [details]
Reference cmd file
Comment 6 quetschke 2006-06-27 04:36:51 UTC
OK, found the problem.

wntmsci10.pro/misc/build/db-4.2.52.NC/mutex/makefile.mk overrides SOLARINC.

/me tests to build without overriding SOLARINC ...
  that fails too, with a different error, obviously there was a reason for this.

Ah, that makefile uses $(PSDKINC), that is not defined here.

This patch fixes the problem for me:

--- db-4.2.52.patch     19 Jun 2006 10:39:16 -0000      1.10
+++ db-4.2.52.patch     27 Jun 2006 03:36:06 -0000
@@ -816,7 +816,7 @@
 ! 
 ! EXTERNAL_WARNINGS_NOT_ERRORS := TRUE
 ! 
-! SOLARINC=-I..$/build_win32 -I..$/ $(PSDKINC) -I$(COMPATH)$/include
+! SOLARINC=-I..$/build_win32 -I..$/ -I$(PSDK_HOME)$/include -I$(COMPATH)$/include
 ! .INCLUDE :  settings.mk
 ! 
 ! 
Comment 7 hjs 2006-06-27 09:26:09 UTC
this in return will break the build in hamburg environment as we don't have
PSDK_HOME :(
an initermediate fix could be to use both. obviously there is some need for a
followup issue to align OOo/SO environment in this point.
Comment 8 hjs 2006-06-27 13:45:23 UTC
temporary fix in CWS warningfixes01 - see #i66781#
Comment 9 hjs 2006-06-27 13:48:32 UTC
please verify
Comment 10 quetschke 2006-07-05 20:26:20 UTC
Works for me with W32-tcsh, logfile see:
<http://go-oo.org/tinderbox/gunzip.cgi?tree=warningfixes01&brief-log=1152096907.2138>
Comment 11 jens-heiner.rechtien 2006-09-05 14:37:30 UTC
Close issue.