Apache OpenOffice (AOO) Bugzilla – Issue 66567
dmake's treatment of .SUFFIXES
Last modified: 2013-08-07 15:34:52 UTC
Dmake's man page claims that: NOTE: .SUFFIXES is ignored by dmake it is used here simply as an example. but that is not true. .SUFFIX is treated as an alias for .SOURCE. IMHO we should remove the special target .SUFFIXES and let the dmake complain about it's usage. (I just found it was used in settings.mk adding 24 "extensions" that were used as possible existing directories where that were to be checked if a target already existed. This might mave a measurable effect on OOo build time.) Also dmakes own makefiles have to be checked for usage of .SUFFIXES.
Added a warning when .SUFFIXES was found, added a testcase and updated the man page. Committed to dmake46. @ause: Please verify.
dmake.nc page 35: "... or by using the .SUFFIXES list of suffixes ..." may give the impression that .SUFFIXES still does something.
I changed that part of the makefile. (Committed to dmake46 with a wrong iz number in the commit message :( ) @ause: Better now?
yes
I committed this to dmake46. Now the warning is only shown if the commandline switch -v[w] is used. +++ dmake/rulparse.c 20 Sep 2006 17:26:44 -0000 @@ -1622,7 +1622,8 @@ case 'S': if( !strncmp( tg, "SOURCE", 6 ) ) DB_RETURN( ST_SOURCE ); else if( !strncmp(tg, "SUFFIXES", 8 )) { - Warning( "The .SUFFIXES target has no special meaning and is deprecated." ); + if (Verbose & V_WARNALL) + Warning( "The .SUFFIXES target has no special meaning and is deprecated." ); DB_RETURN( ST_SOURCE ); } break; @ause: You might want to "re-verify" this issue.
Thanks for making the -v[w] change. That's much appreciated. I'm happy with dmake 4.6 now, and will upload a binary build of it as it currently is to CPAN later today.
.