Issue 6635 - X11 version aborts when using OroborosX 0.8 window manager
Summary: X11 version aborts when using OroborosX 0.8 window manager
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: philipp.lohmann
QA Contact: issues@porting
URL:
Keywords:
: 4395 (view as issue list)
Depends on:
Blocks:
 
Reported: 2002-07-29 16:47 UTC by seanburke
Modified: 2004-03-25 07:31 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description seanburke 2002-07-29 16:47:18 UTC 
When running OOo 1.0 with the OrorbosX 0.8 beta window manager,
an abort happens in XGetWindowProperty:

        #0  0x7001a70c in kill ()
        #1  0x7006f990 in abort ()
        #2  0x00e8fb88 in XError__7SalXLibP9_XDisplayP11XErrorEvent ()
        #3  0x00e8f254 in sal_XErrorHdl ()
        #4  0x011788ac in _XError ()
        #5  0x01177130 in _XReply ()
        #6  0x011629c4 in XGetWindowProperty ()
        #7  0x00e9ecf8 in __Q27vcl_sal14GnomeWMAdaptorP10SalDisplay ()
        #8  0x00e9e158 in createWMAdaptor__Q27vcl_sal9WMAdaptorP10SalDisplay

where it is called from vcl/unx/source/app/wmadaptor.cxx,
GnomeWMAdaptor::GnomeWMAdaptor at line 614:

    if( m_bValid
        && XGetWindowProperty( m_pDisplay,
                               m_pSalDisplay->GetRootWindow(),
                               m_aWMAtoms[ WIN_PROTOCOLS ],
                               0, 0,
                               False,
                               XA_ATOM,
                               &aRealType,
                               &nFormat,
                               &nItems,
                               &nBytesLeft,
                               &pProperty ) == 0

It appears that OroborosX does not correctly support the
Gnome2 window manager protocol, and that the query above
for the "_WIN_PROTOCOLS" property is returning XBadAtom.

While this is arguably a fault in the window manager, it 
seems that the error can be safely ignored, and so we
could SetIgnoreXErrors( TRUE ); during this call to avoid
aborting.

We have notified Adrian Umpleby, the OroborosX developer,
about this issue.
Comment 1 Unknown 2002-07-29 17:00:57 UTC 
I can confirm that this happens on my system too (PB G4, OS 10.1.5,
OroborOsX-0.8b). 
Adrian Umpleby (the OroborOSX author) confirmed in a not that it seems
to be an Oroborus/OroborOSX issue and they are trying to fix it).
Comment 2 philipp.lohmann 2002-07-29 18:02:12 UTC 
will capture the missing X atom
Comment 3 fa 2002-07-29 19:19:40 UTC 
Philipp,

Can you commit to OOO_STABLE_1 and OOO_STABLE_1_PORTS if you get a 
chance?  We're going to start using OOO_STABLE_1_PORTS for the MacOS 
X/Darwin integration once this whole media junk blows over, and we 
might need this change for compatibility.

Dan
Comment 4 philipp.lohmann 2002-07-30 09:27:39 UTC 
fixed with the following revisions of vcl/unx/source/app/wmadaptor.cxx

top level: 1.36
OOO_STABLE_1: 1.28.2.4
OOO_STABLE_1_PORTS: 1.28.2.3.2.1
Comment 5 seanburke 2002-08-25 08:29:28 UTC 
The OroboroX v0.8b2 release (second beta) fixes this
problem also - OOo 1.0 works with v0.8b2.
Comment 6 christof.pintaske 2003-01-20 12:22:56 UTC 
*** Issue 4395 has been marked as a duplicate of this issue. ***
Comment 7 Martin Hollmichel 2004-03-25 07:31:19 UTC 
close issue.