Apache OpenOffice (AOO) Bugzilla – Issue 65083
oowintool issues confusing output
Last modified: 2013-09-12 15:21:06 UTC
in the sense that the average windoze user will see something like this: ... checking for dbghelp.dll... found Can't find MS Visual Studio / VC++ at ./oowintool line 173. checking for msvcp71.dll/msvcr71.dll... found Can't find MS Visual Studio / VC++ at ./oowintool line 173. ... and end up completely helpless ;) I call configure like this: $ ./configure --with-cl-home="/cygdrive/k/MSVS2003/Vc7" --with-csc-path=/cygdrive/c/WINDOWS/Microsoft.NET/Framework/v1.1.4322 --with-jdk-home="/cygdrive/c/j2sdk1.4.2_10" --with-ant-home=/cygdrive/c/apache-ant-1.6.5 and the compiler comes obviously from a network resource, no registry entry.
Is target 2.0.4 really needed here?
Tor - did you look at this ? should be a doddle to fix - right ?
Eh, no? I don't see any easy way how to fix this. Should we add "only local installations of MS Visual Studio are supported" to the error message?
Well - surely, since the paths are specified and the pieces found anyway - could we not check them first, and not fork oowintool if the stuff is found already ?
I don't think it's that trivial. The invocation of oowintool --msvc-productdir in configure.in is already conditional and not done if --with-cl-home has been entered. As the output snippet in the Description has the oowintool error message after "checking for dbghelp.dll", I assume it's the oowintool --msvc-copy-dlls invocation that produces the first error message. The code for that in oowintool needs to know the version of the installed MSVC, and has mapping from version numbers to the version number as it occurs in the C library DLL name. Deducing that from just running cl requires more mappings, from the blurb output by cl ("Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 13.10.3077 for 80x86") to "70" for instance. Etc.
Your code relies on the registry keys, so short of introducing an few extra enviroment variables to hold the compiler information, I would say just change the abort message to something like: "Compiler location not found, relying on configure" or so and don't use die(), use exit() so that we don't get the ugly perl debug info.
reset target to 2.1
DevTools target. Not product related, but build-time related.
Still annoying ...