Apache OpenOffice (AOO) Bugzilla – Issue 63339
Build fails in officecfg
Last modified: 2006-04-18 15:50:55 UTC
The m160 / W32-tcsh build fails in officecfg with: -------------+ validating and creating a locale independent file mkdir.pl ../../../../wntmsci10.pro/misc/registry/data/org/openoffice/ guw.pl java -classpath /cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/xml-apis.jar:/cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/xercesImpl.jar:../../../../wntmsci10.pro/class/cfgimport.jar -Djavax.xml.parsers.SAXParserFactory=org.apache.xerces.jaxp.SAXParserFactoryImpl org.openoffice.configuration.Inspector Inet.xcu ** Start validating: file:d:/w1/tin_ws/officecfg/registry/data/org/openoffice/Inet.xcu ** Document is valid! guw.pl java -classpath /cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/xt.jar:/cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/xercesImpl.jar:../../../../wntmsci10.pro/class/cfgimport.jar -Dcom.jclark.xsl.sax.parser=org.apache.xerces.parsers.SAXParser com.jclark.xsl.sax.Driver Inet.xcu ../../../../util/data_val.xsl ../../../../wntmsci10.pro/misc/registry/data/org/openoffice/Inet.val xcs=/cygdrive/d/w1/tin_ws/officecfg/registry/data/org/openoffice/../../../../registry/schema/org/openoffice/Inet.xcs schemaRoot=/cygdrive/d/w1/tin_ws/officecfg/registry/data/org/openoffice/../../../../registry/schema java.net.UnknownHostException: d dmake: Error code 1, while making '../../../../wntmsci10.pro/misc/registry/data/org/openoffice/Inet.xcu' ---* tg_merge.mk *--- ERROR: Error 65280 occurred while making /cygdrive/d/w1/tin_ws/officecfg/registry/data/org/openoffice This smells like this <http://lists.xml.org/archives/xml-dev/200504/msg00571.html> problem as my java stuff is on c:
me too. I've got "...: f" because I'm building on f: ;-)
Hmm, moving ant to d:/ didn't help. Actually this doesn't look right: ** Start validating: file:d:/w1/tin_ws/officecfg/registry/data/org/openoffice/Inet.xcu
Created attachment 35064 [details] does this work ?
Attached is the fix I suggested when this cropped up during the m160 Hamburg build. I guess it must have worked for the Hamburg windows build, but didn't get committed as a HEAD fix.
reassign
rt -> cmc: If I am reading right, the patch you suppose has already been applied by Ivo on your CWS jaxpapi (see rev. 1.2.88.2 of officecfg/org/openoffice/configuration/FileHelper.java) and is part of the (failing) code which leads to this issue.
in m160 we currently have: try { absPath = "file://" + sSource.replace('\\','/'); } catch (Exception e) caolans patch introduce a getAbs function call: absPath = "file://" + aFile.getAbsolutePath().replace('\\', '/'); Can some test his please ?
Either one should be ok I think. The original code had getAbsoluteFile().toURL().toString() so my patch retained that getAbsolute... semantic. The one that is in SRC680_m160 is an optimization of that and should probably also be ok. So it all looks like the expected-to-work code is in the right place with the right tag :-( Strangely the error shown in the build log looks exactly like what the error would be if no fix was in place. Are we sure that this problem exists with version 1.3 of officecfg/org/openoffice/configuration/FileHelper.java
Other question is what happend if the build sources are placed in a directory /mybuild/äöß/src ? The special characters "äöß" need to be uu encoded in a correct URL. Does a getAbsolutePath() function call trigger such problems ?
Created attachment 35072 [details] 4nt build log
Hi, I aplied (m160): +++ org/openoffice/configuration/FileHelper.java 20 Mar 2006 23:16:37 -0000 @@ -62,7 +62,7 @@ File aFile = new File(sSource); try { - absPath = "file://" + sSource.replace('\\','/'); + absPath = "file://" + aFile.getAbsolutePath().replace('\\','/'); } catch (Exception e) { removed wntmsci10.pro and started, build again: And still get:-------------+ validating and creating a locale independent file mkdir.pl ../../../../wntmsci10.pro/misc/registry/data/org/openoffice/ guw.pl java -classpath /cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/jaxp.jar:/cygdrive/d/w 1/tin_ws/solver/680/wntmsci10.pro/bin/parser.jar:../../../../wntmsci10.pro/class/cfgimport.jar - Djavax.xml.parsers.SAXParserFactory=com.sun.xml.parser.SAXParserFactoryImpl org.openoffice.confi guration.Inspector Inet.xcu ** Start validating: file:d:/w1/tin_ws/officecfg/registry/data/org/openoffice/Inet.xcu ** Document is valid! guw.pl java -classpath /cygdrive/d/w1/tin_ws/solver/680/wntmsci10.pro/bin/xt.jar:/cygdrive/d/w1/ tin_ws/solver/680/wntmsci10.pro/bin/parser.jar:../../../../wntmsci10.pro/class/cfgimport.jar -Dc om.jclark.xsl.sax.parser=com.sun.xml.parser.Parser com.jclark.xsl.sax.Driver Inet.xcu ../../../. ./util/data_val.xsl ../../../../wntmsci10.pro/misc/registry/data/org/openoffice/Inet.val xcs=/cy gdrive/d/w1/tin_ws/officecfg/registry/data/org/openoffice/../../../../registry/schema/org/openof fice/Inet.xcs schemaRoot=/cygdrive/d/w1/tin_ws/officecfg/registry/data/org/openoffice/../../../. ./registry/schema java.net.UnknownHostException: d dmake: Error code 1, while making '../../../../wntmsci10.pro/misc/registry/data/org/openoffice/ Inet.xcu' ---* tg_merge.mk *--- ERROR: Error 65280 occurred while making /cygdrive/d/w1/tin_ws/officecfg/registry/data/org/openo ffice
Created attachment 35105 [details] After more investigation
After a hellish morning trying to create enough of a build environment under windows despite not have a windows compiler I end up with this patch :-) Windows java toURL and friends are not consistent with unix ones, and put a trailing slash at the end of directories. So does this new patch work for everyone ?
GNU/Linux/x86: OK, Windows/tcsh: OK! Caolan: thanks!
looks good on 4nt too. I am going to open a cws to add this fix asap. Thanks
fix applied to cws jaxpapifixer
Issue verified on GNU/Linux x86 and Windows with tcsh.
closed