Hi Robert, is this a regression?
Is this a problem introduced with 1.0.1?

Hi,  
  
I think I found the problem.  The following icons use a 32bit color  
depth (all of the others seem to be 8 bit depth).  
  
/src2/openoffice-1.0.x/sysui/oounix/office/cde/icons/001_star_butterfly.l.xpm  
/src2/openoffice-1.0.x/sysui/oounix/office/cde/icons/ooo_gulls.l.xpm  
  
So these need to be fixed (reduced to 8 bit depth) for the next  
release. This was not a regression in 1.0.1 since 1.0 has the same  
problem.  
  
I will review the color depth of all of the new icons and make sure  
they are 8 bits or less for the next release.  
  
Hope this helps,  
  
Kevin  
  
  
  

Hi Lee,
as far as I know, you have made the OOo icons.

> The following icons use a 32bit color depth (all of the others seem
to be 8 bit depth).
>
>
/src2/openoffice-1.0.x/sysui/oounix/office/cde/icons/001_star_butterfly.l.xpm
 
> /src2/openoffice-1.0.x/sysui/oounix/office/cde/icons/ooo_gulls.l.xpm 

They are not really "32bit" color depth. The xpm color table for these
icons has more than 256 entries so that 'xv' (for example) renders them
in "24-bit mode" "true color".

ooo_gulls.l.xpm (== 001_star_butterfly.l.xpm) actually
uses 83 unique colors.  And ooo_gulls.m.xpm uses 116 unique colors.

  
> So these need to be fixed (reduced to 8 bit depth) for the next release.

Not only that, they should use *much* *fewer* color map entries.
Currently the set of CDE icons (ooo_gulls.l.xpm for the front panel
icon and ooo_*.m.xpm for the icons in the front panel popup menu)
require 146 color cells.

The CDE icons for SO 6.0 use 29 unique colors and that includes the 
set of 20 standard CDE colors + transparent color.

I'll attach an updated set of OO CDE icons.  Install them into
oo_1.0.1_src/sysui/oounix/office/cde/icons . All new icons plus the
original SO 6.0 icons combined use a shared color map of 33 colors.
With this icon set the corrupted OO icons are gone on an Ultra60 +
Creator3D with a default visual of 8-bit pseudocolor.  And there are
free color cells left for application programs that use 8-bit pseudo
color, so there's reduced colormap flashing as well!

Created attachment 2410 [details]
gzipped tar archive with new CDE icon images in XPM format

Created attachment 2419 [details]
Updated xpm icons, the C variable names in the previous attachment were wrong

This issue should be reassigned to component "gsl" / "code", I think...

Can someone please review the patch (new icons, 
2002-08-02 13:28 PDT: oo-cde-icons.tar.gz) and approve them for
check in?

Hi Kevin

My apologies for passing the buck onto you, but this issue seems to be
stuck with me, and I am only the icon tweaker and would have no idea
how to check the patch! :-)

I'd appreciate it if you could either take this one over or reassign
to somebody more appropriate.

Many thanks.

Lee

 Hi, 
 
This seems to be mine now.  I will grab your new icons and check the 
C includes to make sure they match the old and then test them on my 
latest 643 buid. 
 
One thing, just to be safe, has the submitter of these icons signed 
a copyright assignment agreement that would allow me to commit them 
to the tree? 
 
Thanks, 
 
Kevin 
 

Hi Kevin,

> has the submitter of these icons

that was me.

> signed 
> a copyright assignment agreement that would allow me to commit them 
> to the tree? 

Yes, I've signed & sent it on 2002-07-30.

My name was added here as well:

  http://www.openoffice.org/copyright/copyrightapproved.html

Hi, 
 
Thanks, I should have looked there myself. 
 
Okay, I will use your icons to replace the xpms used for KDE and CDE 
(GNOME uses the .pngs I believe) and try a clean rebuild to make 
sure they won't break anything. 
 
Once I can get the clean rebuild done and everything works, I will 
get them committed to the SRX643_OO tree and try to do the same for 
OOO_STABLE_1 so that any possible 1.0.2 followup is ready to go as 
well. 
 
Thanks, 
 
Kevin 
  

Hi, 
 
Your icons look fine.  I edited the C header slightly to add a space 
before the variable name just to match the original and for 
readability. 
 
I used them to replace the icons for cde, and kde and rebuilt sysui, 
desktop, and vcl and reinstalled. 
 
I do not have access to cde to check if this has fixed the problem 
but under kde2, they all look fine. 
 
I will commit this to SRX643_OO. 
 
Once a new release (after the one made today or tomorrow), the 
problem will hopefully be gone.   
 
Thanks for your bug report and your icons! 
 
Kevin 
  

Reopening issue for OpenOffice.org build 1.0.2 Solaris sparc 9 FCS. 

issue also seen on build 1.1Beta

Hi, 
 
These icons (see the last attachment) were actually committed to my tree and fixed the 
corruption problem so they should probably be committed to OOO_STABLE_1 and 
1.1Beta as well. 
 
I will try to do that sometime today if someone can approve these. 
 
Kevin 
 
 

this problem still exists in build
OOo_1.0.3b_SolarisSparc_install.tar.gz on collab

Hi, 
 
Yes it will exist in all builds but the one I fixed it in originally and will until I replace the 
icons in sysui/oounix/ with the icons attached to this issue and commit them. 
 
I should have time to do that tonight. 
 
Kevin 
 

fixed / verified in build 1.0.3 c, will not mark as verified until fix
is also confirmed fixed in 1.1 Beta2 - changing target to 1.1Beta2

corrupt icons are present in latest Solaris Sparc 1.1 beat2 build when
graphics mode set to operate in 8 bit mode. Also the Maths menu item
is missing from the cde OO.org menu.
Resetting version ot 1.1Beta2, leaving target as 1.1Beta2.
Reopening issue

Hi, 
 
Okay, I just copied known good files from the OOo 1.0.3 icons  
which had this fixed and used them to updat ehte icons in 
sysui/oounix/office/cde/icons/ 
 
So  after a clean rebuild and forced delivery in sysui, the corrupt icons 
should now be fixed. 
 
(I hope!). 
 
Kevin 
 

the corrupt CDE icon in 8 bit mode is fixed in the latest build
(1.1beta2d). 
The math menu item is still missing - see issue 14355.
Closing this issues as fixed

marking issue verified

verified fixed - closing issue