Issue 61638 - Don't import every environment variable as dmake macro
Summary: Don't import every environment variable as dmake macro
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-06 02:03 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for config_office/ (4.66 KB, patch)
2006-02-06 02:04 UTC, quetschke 		no flags Details | Diff
Patch for solenv/ (1.57 KB, patch)
2006-02-06 02:05 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-02-06 02:03:17 UTC 
As discussed on IRC. Not importing every environment variable as dmake macro
but only the used ones can give more control over the macros used in the build
environment.

The following two patches provide this for the OOo environment. importenv.mk is
generated while running configure (set_soenv). Currently importenv.mk is
generated directly in solver/... but in a final version this file should be
created alongside *env.set and copied by it (*env.set) if the OOo environment
is set up.

This patch survived a full OOo W32-tcsh build and it should be fairly straight
forward to implement something like this into setsolar.pl.
Comment 1 quetschke 2006-02-06 02:04:15 UTC 
Created attachment 33864 [details]
Patch for config_office/
Comment 2 quetschke 2006-02-06 02:05:05 UTC 
Created attachment 33865 [details]
Patch for solenv/
Comment 3 quetschke 2006-02-06 02:21:14 UTC 
What I did was the following: While set_soenv generates the *env.set file it
remembers the names of the written environment variables. Then it adds the
variable to the list of imported macros
   $SOLARVERSION/$INPATH/inc/importenv.mk
if it is not excluded by
   solenv/inc/dmakenoimport.lst

Additional, any variable that is mentioned in
   solenv/inc/dmakeextraimport.lst
is also added to importenv.mk.

And finally dmake doesn't import all environment variable any longer but
uses importenv.mk instead.
Comment 4 hjs 2006-03-13 12:37:33 UTC 
set target...