Apache OpenOffice (AOO) Bugzilla – Issue 61419
Redundant locale icons in 'Res'
Last modified: 2017-05-20 11:30:59 UTC
The following directories contain what I believe are redundant icons: ui/default_images/res/cs ui/default_images/res/de ui/default_images/res/es ui/default_images/res/fr ui/default_images/res/hu ui/default_images/res/it They contain variations of icons 10008, 10009, 10014 and 26648. These icons were removed with the 'big-icon-clean-up' (Issue 37197). However, 1 month later the CWS sj16 was integrated, that added some of these icons back in. I suspect they need deleting. Regards, Andrew
OK for CWS icons02?
Go for CWS icons02. However, again please validate these are truely redundant against source. Cheers.
The duplicates here should use the icon from res/commandimagelist, so I think that there's no problem with removing these. pjanik: Is it really so, please? Here's the list of the icons I've removed (using a script that checks for the duplicates.) CVS: res/commandimagelist/cs/lc_bold.png CVS: res/commandimagelist/cs/lc_italic.png CVS: res/commandimagelist/cs/lc_numberformatdecimal.png CVS: res/commandimagelist/cs/lc_underline.png CVS: res/commandimagelist/cs/lc_underlinedouble.png CVS: res/commandimagelist/cs/lch_bold.png CVS: res/commandimagelist/cs/lch_italic.png CVS: res/commandimagelist/cs/lch_numberformatdecimal.png CVS: res/commandimagelist/cs/lch_underline.png CVS: res/commandimagelist/cs/lch_underlinedouble.png CVS: res/commandimagelist/cs/sc_bold.png CVS: res/commandimagelist/cs/sc_italic.png CVS: res/commandimagelist/cs/sc_numberformatdecimal.png CVS: res/commandimagelist/cs/sc_underline.png CVS: res/commandimagelist/cs/sc_underlinedouble.png CVS: res/commandimagelist/cs/sch_bold.png CVS: res/commandimagelist/cs/sch_italic.png CVS: res/commandimagelist/cs/sch_numberformatdecimal.png CVS: res/commandimagelist/cs/sch_underline.png CVS: res/commandimagelist/cs/sch_underlinedouble.png CVS: res/commandimagelist/de/lc_underline.png CVS: res/commandimagelist/de/lch_underlinedouble.png CVS: res/commandimagelist/de/sch_numberformatdecimal.png CVS: res/commandimagelist/en-GB/lc_bold.png CVS: res/commandimagelist/en-GB/lc_italic.png CVS: res/commandimagelist/en-GB/lc_numberformatdecimal.png CVS: res/commandimagelist/en-GB/lc_underline.png CVS: res/commandimagelist/en-GB/lc_underlinedouble.png CVS: res/commandimagelist/en-GB/lch_bold.png CVS: res/commandimagelist/en-GB/lch_italic.png CVS: res/commandimagelist/en-GB/lch_numberformatdecimal.png CVS: res/commandimagelist/en-GB/lch_underline.png CVS: res/commandimagelist/en-GB/lch_underlinedouble.png CVS: res/commandimagelist/en-GB/sc_bold.png CVS: res/commandimagelist/en-GB/sc_italic.png CVS: res/commandimagelist/en-GB/sc_numberformatdecimal.png CVS: res/commandimagelist/en-GB/sc_underline.png CVS: res/commandimagelist/en-GB/sc_underlinedouble.png CVS: res/commandimagelist/en-GB/sch_bold.png CVS: res/commandimagelist/en-GB/sch_italic.png CVS: res/commandimagelist/en-GB/sch_numberformatdecimal.png CVS: res/commandimagelist/en-GB/sch_underline.png CVS: res/commandimagelist/en-GB/sch_underlinedouble.png CVS: res/commandimagelist/es/sch_numberformatdecimal.png CVS: res/commandimagelist/et/lc_bold.png CVS: res/commandimagelist/et/lc_italic.png CVS: res/commandimagelist/et/lc_numberformatdecimal.png CVS: res/commandimagelist/et/lc_underline.png CVS: res/commandimagelist/et/lc_underlinedouble.png CVS: res/commandimagelist/et/lch_bold.png CVS: res/commandimagelist/et/lch_italic.png CVS: res/commandimagelist/et/lch_numberformatdecimal.png CVS: res/commandimagelist/et/lch_underline.png CVS: res/commandimagelist/et/lch_underlinedouble.png CVS: res/commandimagelist/et/sc_bold.png CVS: res/commandimagelist/et/sc_italic.png CVS: res/commandimagelist/et/sc_numberformatdecimal.png CVS: res/commandimagelist/et/sc_underline.png CVS: res/commandimagelist/et/sc_underlinedouble.png CVS: res/commandimagelist/et/sch_bold.png CVS: res/commandimagelist/et/sch_italic.png CVS: res/commandimagelist/et/sch_numberformatdecimal.png CVS: res/commandimagelist/et/sch_underline.png CVS: res/commandimagelist/et/sch_underlinedouble.png CVS: res/commandimagelist/fr/lc_italic.png CVS: res/commandimagelist/km/lc_numberformatdecimal.png CVS: res/commandimagelist/km/lch_numberformatdecimal.png CVS: res/commandimagelist/km/sc_numberformatdecimal.png CVS: res/commandimagelist/km/sch_numberformatdecimal.png CVS: res/commandimagelist/sk/lc_bold.png CVS: res/commandimagelist/sk/lc_italic.png CVS: res/commandimagelist/sk/lc_numberformatdecimal.png CVS: res/commandimagelist/sk/lc_underline.png CVS: res/commandimagelist/sk/lc_underlinedouble.png CVS: res/commandimagelist/sk/lch_bold.png CVS: res/commandimagelist/sk/lch_italic.png CVS: res/commandimagelist/sk/lch_numberformatdecimal.png CVS: res/commandimagelist/sk/lch_underline.png CVS: res/commandimagelist/sk/lch_underlinedouble.png CVS: res/commandimagelist/sk/sc_bold.png CVS: res/commandimagelist/sk/sc_italic.png CVS: res/commandimagelist/sk/sc_numberformatdecimal.png CVS: res/commandimagelist/sk/sc_underline.png CVS: res/commandimagelist/sk/sc_underlinedouble.png CVS: res/commandimagelist/sk/sch_bold.png CVS: res/commandimagelist/sk/sch_italic.png CVS: res/commandimagelist/sk/sch_numberformatdecimal.png CVS: res/commandimagelist/sk/sch_underline.png CVS: res/commandimagelist/sk/sch_underlinedouble.png CVS: res/commandimagelist/sv/lc_underline.png CVS: res/commandimagelist/sv/lch_underlinedouble.png
This was not the case in the past, thus we introduced them at all. Please verify in the final instset...
Forgot to add - removed in CWS icons02.
ace_dent: Could you double-check, please? If they are really necessary so far, we should fix the code so that it can fallback nicely...
Kendy: for sure there is icon duplication at the localisation level, and this should be removed and fallback nicely. However, can we investigate this in a seperate issue? The purpose of this issue is to just remove the locale icons which are in the wrong place and probably unrequired. To re-state: ui/default_images/res/cs .../de .../es .../fr .../hu .../it For removing the locale specific icons from commandimagelist, there are more issues that are involved. For instance '/ar' duplicates the standard icon set, but is using older icons, etc. I'd imagine these icons are also referenced by helpfiles and some code changes might be required. So can I raise this point as a seperate issue for later? : 'Remove duplicate locale icons in commandimagelist'.
Adjusting target.
->Sun's ArtTeam (icon issue): Re-opening issue and re-assigning to 'sts' for feedback. [icons]
.
STS -> GH: Do you know if those icons are really redundant?
gh -> sts: no idea, sorry
set target OOo 3.0
STS -> VA: hi volker, i could not figure out if these icons are actual redundant or used for localization... STS -> VA & HJS: what du you think? should we keep all these icons and close this issue?
for the icons beside those in res/commandimagelist the *.ilst show if they are used or not. if the localized version shows up in the *.ilst and is identical with the default (non localized) version, the localized version isn't needed. the same check for localized vs. non localized icons is valid for icons in res/commandimagelist too. unfortunately i don't know an easy way to find out if a specific icon is used at all... @sts: no, i don't want to keep icons that are good for nothing...
Set new target.
Reset assigne to the default "issues@openoffice.apache.org".