Issue 58565 - variable names in package lists must have a defined end
Summary: variable names in package lists must have a defined end
Status: ACCEPTED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: 680m142
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 58567 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-11-28 14:28 UTC by hjs
Modified: 2013-08-07 15:26 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2005-11-28 14:28:45 UTC 
when doing variable replacement, the currently used construct %NAME doesn't
state the end of the variable name. having two variables like %NAME and
%NAMEANDMORE will work only by chance if the order of replacements fit (see
#i58503#).
also strings not intended to be replaced will be included in the match.

changing variable usage in these lists form %NAME to %NAME% (and the replacing
code ;)) might help to solve this problem.
Comment 1 ingo.schmidt-rosbiegal 2005-11-28 14:47:55 UTC 
*** Issue 58567 has been marked as a duplicate of this issue. ***
Comment 2 ingo.schmidt-rosbiegal 2005-11-28 15:01:54 UTC 
This is a little bit problematic, because all occurences of for example
%PRODUCTNAME and %PRODUCTVERSION  in all languages are affected by such a
change. Many strings in the translation database and in nearly all ulf files in
scp2 projects have to be changed.
Comment 3 pavel 2006-01-18 20:09:26 UTC 
is: so 2.0.2 is problematic? If so, please retarget accordingly.
Comment 4 ingo.schmidt-rosbiegal 2006-01-19 10:00:26 UTC 
Yes, I think this is one of the most dangerous changes we can do. Nearly all
strings in the translation database have to be changed and nearly all strings in
scp projects. Probably there are also Configuration settings that have to be
adapted. Furthermore the packing process has to be adapted at several different
positions, because the Windows Installer uses another syntax for dynamic
variable replacement than our Java installer. Again a different syntax is used
in our own setup script. 
The mechanism with variables like %PRODUCTNAME and %PRODUCTVERSION is used for
many years and we had only one time one little string,  in which a wrong
variable was replaced. In my opinion there is no need to change this behaviour
in SO8/OOo2 versions. 
We should do this for OOo 3.
Setting corresponding target.
Comment 5 ingo.schmidt-rosbiegal 2006-06-27 11:21:24 UTC 
Setting new target
Comment 6 ingo.schmidt-rosbiegal 2006-10-11 11:22:49 UTC 
Accepted
Comment 7 ingo.schmidt-rosbiegal 2007-11-26 14:12:09 UTC 
Target OOo 3.0
Comment 8 ingo.schmidt-rosbiegal 2008-05-27 16:10:43 UTC 
Target OOo 3.x