Issue 56633 - document converter wizard fails when compatability is enabled
Summary: document converter wizard fails when compatability is enabled
Status: CONFIRMED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOO 2.0 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-25 17:08 UTC by noel.power
Modified: 2013-07-30 02:46 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description noel.power 2005-10-25 17:08:57 UTC
ImportWizard.FileModul.ReadCollectionPaths has 2 variables undefined even though
option 'EXPLICIT' is set. 

undefined variable are oDocInfo & bInterruptSearch

A seperate issue seems that BASIC does not detect this situation ( the variables
in question are defined in Tools.UCB ) and have no scoping keyword ( therefore
are private ). On SUSE & Novell systems basic is built with compatability=on by
default, this results in an extra check picking up the error above the results
in the DocumentConvertor failing.

To see the error you need to simulate that the compatability option is turned on
e.g. insert the line
"CompatibilityMode( true )" 
just after the function definition for ReadCollectionPaths

The fix is to simply patch the module, I'll open a seperate issue for the fact
that basic does not detect that the variables are not defined/dim-ed when option
'explicit' is set.


Index: FilesModul.xba
===================================================================
RCS file: /cvs/installation/wizards/source/importwizard/FilesModul.xba,v
retrieving revision 1.44
diff -u -p -r1.44 FilesModul.xba
--- FilesModul.xba      13 May 2005 09:43:43 -0000      1.44
+++ FilesModul.xba      25 Oct 2005 16:21:16 -0000
@@ -41,6 +41,8 @@ Dim NewContentList() as String
 Dim XMLTemplateContentString as String
 Dim ApplIndex as Integer
 Dim bAssignFileName as Boolean
+Dim oDocInfo as Object
+Dim bInterruptSearch as Boolean
        oDocInfo =
CreateUnoService("com.sun.star.document.DocumentProperties")
        bInterruptSearch = False
        For i = 0 To MaxCollectIndex
Comment 1 Olaf Felka 2005-10-25 18:32:54 UTC
of @ bc: Is this your portion?
Comment 2 berend.cornelius 2005-12-02 13:44:51 UTC
BC->IH: Document Converter is now yours
Comment 3 nospam 2008-07-02 09:43:41 UTC
what fix do you suggest here?

Comment 4 noel.power 2008-07-06 16:19:09 UTC
how about the inline patch suggested in the first comment?
Comment 5 inlawcada 2010-10-23 15:06:14 UTC
Created attachment 72406
Comment 6 Rob Weir 2013-07-30 02:46:48 UTC
Reset assignee on issues not touched by assignee in more than 1000 days.