Issue 54989 - border missing in printed impress handouts
Summary: border missing in printed impress handouts
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: printing (show other issues)
Version: OOO 2.0 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.4
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
: 70212 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-09-23 01:13 UTC by ccooper
Modified: 2006-10-09 09:01 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed patch (797 bytes, patch)
2006-05-02 19:08 UTC, thb 		no flags Details | Diff
the patch of this bug (639 bytes, patch)
2006-10-09 09:01 UTC, liujiaxiang 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ccooper 2005-09-23 01:13:24 UTC 
Printed handouts are printing only the text of the slides--not the border/frame
that encloses the text. Does not matter what layout you choose (1-6 slides per
page).
Comment 1 wolframgarten 2005-09-23 07:52:55 UTC 
Reproducible. Reassigned.
Comment 2 ccooper 2005-11-28 01:28:13 UTC 
tried again using OO 2.0.1 rc1--issue still there--not printing the border or 
"frame" that encloses the text of the individual slides
Comment 3 ccooper 2006-02-20 03:51:24 UTC 
Still no go with this problem in 2.02--any timeline for a fix? Works in 1.5. I 
am tired of having to use microsoft powerpoint to print my slides.
Comment 4 freemant 2006-03-31 10:17:06 UTC 
A workaround is to add a rectangle to the master slide.

Is this bug so difficult to fix? I think this is a show stopper.
Comment 5 wolframgarten 2006-03-31 10:25:41 UTC 
Set this one to broken - thanks for the hint.
A showstopper would be a bug that makes it hard to work with the product -
dataloss, crash or something like that. I do not think that the missing outline
is so severe.
Comment 6 freemant 2006-03-31 14:23:18 UTC 
Well, I believe most people preparing slides will finally print them out. If
there is no border, then it won't look right. Take our organization as an
example, we run many training courses and need to print out the slides from the
instructors. Due to the missing border, the printout will be very hard to read.
Comment 7 thb 2006-05-02 19:08:43 UTC 
Created attachment 36219 [details]
Proposed patch
Comment 8 thb 2006-05-02 19:11:44 UTC 
@aw: added a patch that fixes the actual problem, only that now on screen, the
border is missing. Something _really_ strange is going on here, if I just skip
the DrawRect call in ViewContactOfPageObj::PaintPageBorder(), the stuff comes
out fine (and no, there does not seem to be an XOR drawmode or something like
that set). 

Please have a look, the old code with aNewRect being given to a const ref and
then unioned still appears rather broken to me...
Comment 9 thb 2006-05-02 19:13:09 UTC 
BTW: happens on all platforms.
Comment 10 Armin Le Grand 2006-07-11 12:36:19 UTC 
AW: Looks like i found something: ViewContactOfPageObj::PaintObject uses
PaintPageBorder, but it does not init the aNewRectangle parameter for the
position and size of the rectangle. Aded, testing...
Comment 11 Armin Le Grand 2006-07-11 12:49:55 UTC 
AW: Okay, works. It also fixes the bug that in handout view the empty frames
were not visible. They need to be visible to be able to change the layout even
with less pages existing then in the slideshow.
AW. Checking in, adding task to aw035.
Comment 12 Armin Le Grand 2006-07-20 14:04:49 UTC 
AW->WG: Please verify.
Comment 13 wolframgarten 2006-07-21 12:09:36 UTC 
Verified in CWS.
Comment 14 wolframgarten 2006-07-31 13:24:15 UTC 
Tested in master m179. Closed.
Comment 15 wolframgarten 2006-10-09 08:09:42 UTC 
*** Issue 70212 has been marked as a duplicate of this issue. ***
Comment 16 liujiaxiang 2006-10-09 08:35:35 UTC 
I agree with AW .  ViewContactOfPageObj::PaintObject uses
PaintPageBorder, but it does not init the aNewRectangle parameter for the
position and size of the rectangle.
**********************************************
-Rectangle aNewRectangle;
+Rectangle aNewRectangle(GetPageRectangle());
**********************************************
Also fixed the bug , I think this is better . please testing , thanks
Comment 17 liujiaxiang 2006-10-09 09:01:32 UTC 
Created attachment 39644 [details]
the patch of this bug