Issue 52746 - Clean up ICC and other historical compiler tags.
Summary: Clean up ICC and other historical compiler tags.
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-01 14:48 UTC by foskey
Modified: 2013-07-30 02:40 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2005-08-01 14:48:10 UTC 
The ICC compiler tag is historical and if it is ever reused will cause problems
with dead code coming out.

This task is to safely remove all references to the ICC compiler tag & OS2
operating system.

Also consider the following tags as possibly redundant:

HPUX
C50, C52  - Solaris versions I think
WTC
MTW
etc...
Comment 1 hjs 2005-08-01 19:11:34 UTC 
HPUX - no idea

C50, C52  - Solaris versions I think - need a closer look as C52 is still used
in solaris environment

WTC - watcom compiler (OS2, WNT?) - obsolete

MTW - metrowerks compiler (mac OS9 ?) - obsolete
Comment 2 foskey 2005-08-03 13:44:40 UTC 
Any idea about BLC macro (see basic module).
Comment 3 hjs 2005-08-03 14:29:12 UTC 
BLC - borland compiler (OS2, win16) - obsolete
Comment 4 foskey 2005-08-03 16:14:05 UTC 
Begun commiting patches.  I need the following added to cleanup01

dmake, setup2, sj2, soltools, sim2, linguistic
Comment 5 hjs 2005-08-03 16:24:45 UTC 
first of all, you should ask mt before committing these changes to his CWS
(he'll never see comments on this issue...).

second you might want to make sure which modules are still in use before doing
cleanup...
Comment 6 quetschke 2005-08-03 20:10:57 UTC 
I don't necessarily see dmake as an Openoffice only module. A cleanup of
"obsolete" compilers IMHO should be avoided unless it is really solves
problems.

If you open a seperate issue for the dmake cleanup we can discuss
applying the patch to CWS dmake43p01. (Currently in "Ready for QA" state, but
ause might still accept changes in that CWS.)
Comment 7 foskey 2005-08-03 23:11:00 UTC 
dmake is making use of an OOo specific define without setting it in it's own
configure script.  By you own rules this is a clean up that should happen. see:

Index: tempnam.c
===================================================================
RCS file: /cvs/tools/dmake/tempnam.c,v
retrieving revision 1.2
diff -r1.2 tempnam.c
98c98
< #if (defined (MSC) || defined (BLC) || defined(ICC) ) && ( defined (WIN) ||
defined (WNT))
---
> #if (defined (MSC) || defined (BLC)) && ( defined (WIN) || defined (WNT))
Comment 8 quetschke 2005-08-04 18:08:38 UTC 
vq->waratah: Oops, yes, none of the macros there looks like they are defined
in a standalone build of dmake. I'll look into all of them. Filed
issue 52899 for this purpose.
Comment 9 Martin Hollmichel 2005-08-10 13:35:04 UTC 
reassign issue to the man who set status "started" :)
Comment 10 stx123 2006-02-20 01:27:23 UTC 
Reassign issue to owner of selected subcomponent
Comment 11 Martin Hollmichel 2006-02-24 09:35:29 UTC 
reassign
Comment 12 Rob Weir 2013-07-30 02:40:10 UTC 
Reset assignee on issues not touched by assignee in more than 1000 days.