50820 – 'hotfix' == memory leak ...

Issue 50820 - 'hotfix' == memory leak ...

Summary: 'hotfix' == memory leak ...

Status:	CLOSED DUPLICATE of issue 50546

Alias:	None

Product:	gsl
Classification:	Code
Component:	code (show other issues)
Version:	680m109
Hardware:	Other All

Importance:	P3 Trivial (vote)
Target Milestone:	---
Assignee:	hdu@apache.org
QA Contact:	issues@gsl

URL:
Keywords:

Depends on:
Blocks:

Reported:	2005-06-16 12:50 UTC by mmeeks
Modified:	2005-06-16 13:47 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	PATCH
Latest Confirmation in:	---
Developer Difficulty:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.

Description mmeeks 2005-06-16 12:50:15 UTC

Looks like this (lazy/fast) fix needs re-visiting, I'm seeing some substantial
leakage from this:

--- vcl/source/gdi/outdev3.cxx  18 May 2005 08:04:00 -0000      1.200
+++ vcl/source/gdi/outdev3.cxx  16 Jun 2005 11:53:43 -0000
@@ -1599,7 +1599,7 @@
     {
         ImplFontData* pFace = mpFirst;
         mpFirst = pFace->GetNextFace();
-#if 0 // HOTFIX for 122732
+#if 1 // HOTFIX for 122732
         delete pFace;
 #endif
     }

That fixes the leak ;-) - what the HOTFIX is supposed to fix I have no idea;
it'd be nice to get the details from that.

Comment 1 philipp.lohmann 2005-06-16 13:19:10 UTC

pl->hdu: he got you :-)

Comment 2 hdu@apache.org 2005-06-16 13:27:01 UTC

The leak was fixed in issue 50820. It was still better than a crash :-)

*** This issue has been marked as a duplicate of 50546 ***

Comment 3 hdu@apache.org 2005-06-16 13:47:34 UTC

Closing duplicate.