Issue 49956 - A dot in find string of Help Viewer loops (crashes) the Office
Summary: A dot in find string of Help Viewer loops (crashes) the Office
Status: CLOSED FIXED
Alias: None
Product: documentation
Classification: Unclassified
Component: Online help (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: h.ilter
QA Contact: issues@documentation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-27 12:18 UTC by Uwe Fischer
Modified: 2005-07-19 13:58 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Uwe Fischer 2005-05-27 12:18:55 UTC 
Open Help Viewer, Find tab page
Enter normal.dot or some.thing as search term and click Find button
Double click the first found entry "Glossary of Internet Terms" - > loop
Found on Win XP and Solaris on SunRay
Comment 1 Uwe Fischer 2005-05-27 13:34:42 UTC 
UFI: I just found that the Help Viewer does not enter an endless loop. It just
needs a very looooong time to select all characters on the help page. So you may
reset the prio from 2 to 3 if you want
Comment 2 andreas.bille 2005-06-17 12:57:21 UTC 
ABI->FME: Apparently, after doing the search, the search text will be marked in
the writer window on the right panel using writer functionality. Here is a
snapshot of the stack, SetSelection is the method which does not return.
	sw680mi.dll!SwNodeIndex::SwNodeIndex()  + 0x32	C++
 	sw680mi.dll!SwPosition::SwPosition()  + 0x12	C++
 	sw680mi.dll!SwCrsrShell::MakeFindRange()  + 0x3b	C++
 	sw680mi.dll!SwCrsrShell::MakeFindRange()  + 0x83	C++
 	sw680mi.dll!SwCrsrShell::ClearUpCrsrs()  + 0x2b	C++
 	sw680mi.dll!SwCrsrShell::UpdateCrsr()  + 0x1a	C++
 	sw680mi.dll!SwCrsrShell::CreateCrsr()  + 0xa1	C++
 	sw680mi.dll!SwCrsrShell::SetSelection()  + 0x52	C++
Comment 3 frank.meies 2005-06-17 14:54:58 UTC 
FME->PB: Please have a look at sfx2/source/appl/newhelp.cxx,
PrepareSearchString(). If 'normal.dot' is passed as parameter, the resulting
search string will be 'normal|.|dot'. Using this for a regexp search will find
every single character, giving us a loop-like behaviour.
Comment 4 pb 2005-06-21 10:20:44 UTC 
pb: you can not search for strings like "normal.dot" because our search engine
takes the dot as a word break. So here we are searching for the strings "normal"
and "dot". But I fixed the "loop".

Fixed in cws fwk16.
Files changed:
/sfx2/source/appl/newhelp.cxx 1.110.62.2
Comment 5 frank.thomas.peters 2005-06-21 10:41:32 UTC 
Which search engine is involved here? Is the same engine used for searching as
for marking the strings on the page? How do I search for a "." then? We should
offer the simplest functionality to the user and that is: search for the literal
that is entered in the search field. Don't assume the users know about "word
boundaries" or "wild cards".
Comment 6 Mathias_Bauer 2005-06-28 11:03:56 UTC 
Retargetted due to importance of the issue.
Comment 7 pb 2005-07-06 12:56:47 UTC 
pb -> hi: please verify, thx. 

re-open issue and reassign to hi@openoffice.org
Comment 8 pb 2005-07-06 12:56:51 UTC 
reassign to hi@openoffice.org
Comment 9 pb 2005-07-06 12:56:56 UTC 
reset resolution to FIXED
Comment 10 h.ilter 2005-07-08 12:26:11 UTC 
Verified with cws fwk16 = ok
Comment 11 h.ilter 2005-07-19 13:58:16 UTC 
Verified with 680m119 = ok