Issue 49761 - Copying a slide master crashes Impress
Summary: Copying a slide master crashes Impress
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: editing (show other issues)
Version: 680m104
Hardware: PC Windows XP
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
: 49775 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-05-24 08:20 UTC by helpman
Modified: 2005-07-25 13:53 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description helpman 2005-05-24 08:20:10 UTC 
In Master view, trying to copy-and-paste an existing master slide crashes OOo
every time.
Example: Create a new presentation. Switch to master view. In the left hand
'slides' panel, select the first available slide master. Copy this using Ctrl-c.
Paste it by using Ctrl-V. OOo crashes.
Comment 1 wolframgarten 2005-05-24 09:20:54 UTC 
Priority changed.
Comment 2 wolframgarten 2005-05-24 09:26:44 UTC 
Reproducible.
Comment 3 wolframgarten 2005-05-24 09:27:15 UTC 
Reassigned.
Comment 4 wolframgarten 2005-05-24 10:59:08 UTC 
*** Issue 49775 has been marked as a duplicate of this issue. ***
Comment 5 clippka 2005-05-24 16:39:48 UTC 
Does not crash at my place but the ui is unstable after this.

The main problem is that our core never was able to transfer a single master
page over the clipboard. I will have a look into this one
Comment 6 clippka 2005-05-25 09:23:09 UTC 
Ok, I evaluated this further.
Problem is that our current clipboard scenario does not work with slide masters.
The root method is (again) InsertBookmarkAsPage() and it works with a list of
page names. There is  no reliable way to know from the page names that they are
master pages and even then pasting may be a problem.

@cl->af: For OOo 2.0.1 I see no way in implementing a clipboard feature for
master slides. Please remove all UI for copy&paste in slide sorter for slide
master mode. This includes context menu, menu, keyboard shortcuts and drag'n'drop

I will write a seperate issue for this on the OOo Later target.
Comment 7 groucho266 2005-05-25 15:36:45 UTC 
Accepted.
Comment 8 groucho266 2005-05-27 10:57:35 UTC 
I have disabled copy-and-paste and drag-and-drop with master pages being the
source or the destination.  This was done basically by 
1) disabling the SID_COPY,SID_PASTE,SID_PASTE2 slots for the slide sorter when
it displays master pages and
2) by not accepting drops of pages while in master page mode.

I have filed issue 49924 about CTRL-V still triggering calls to the SID_PASTE
slot even though that is disabled.  A workaround in SlsClipboard.cxx is in place.

Affected files:
/sd/source/ui/slidesorter/controller/SlsClipboard.cxx    rev. 1.12.42.1
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.16.28.3
/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx    rev. 1.5.44.1
/sd/source/ui/view/sdview2.cxx    rev. 1.42.66.1
Comment 9 groucho266 2005-06-28 15:59:39 UTC 
Reopening and setting target to OOo 2.0
Comment 10 groucho266 2005-06-28 17:08:13 UTC 
Integrated fix into CWS impress62:
/sd/source/ui/slidesorter/controller/SlsClipboard.cxx    rev. 1.12.74.1
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.16.60.1
/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx    rev. 1.5.76.1
/sd/source/ui/view/sdview2.cxx    rev. 1.42.98.1
Comment 11 groucho266 2005-06-29 16:43:32 UTC 
Back to QA for verification.

re-open issue and reassign to cgu@openoffice.org
Comment 12 groucho266 2005-06-29 16:43:38 UTC 
reassign to cgu@openoffice.org
Comment 13 groucho266 2005-06-29 16:43:43 UTC 
reset resolution to FIXED
Comment 14 christian.guenther 2005-07-04 13:25:39 UTC 
Verified in cws impress62
Comment 15 christian.guenther 2005-07-25 13:52:48 UTC 
Integrated in src680m121.
Comment 16 christian.guenther 2005-07-25 13:53:47 UTC 
Integrated