Issue 49491 - Double click on Calc statusbar does not show Navigator
Summary: Double click on Calc statusbar does not show Navigator
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: ui (show other issues)
Version: 680m103
Hardware: All All
: P4 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords: oooqa, rfe_eval_ok
Depends on:
Blocks:
 
Reported: 2005-05-19 10:35 UTC by kami911
Modified: 2013-08-07 15:14 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch to enable Navigator from statusbar - I will test it in my builds (568 bytes, patch)
2006-02-10 12:55 UTC, kami911
no flags Details | Diff
draf version of specification - I hope it is enough :o) (15.76 KB, application/vnd.sun.xml.writer)
2006-02-10 18:12 UTC, kami911
no flags Details
patch that works (1.55 KB, patch)
2007-12-05 21:16 UTC, kyoshida
no flags Details | Diff
a little cosmetic change to make it look more blended in. (1.64 KB, patch)
2007-12-05 21:23 UTC, kyoshida
no flags Details | Diff
Draft specification for statusbar behaviors - passed to UX list (70.79 KB, application/vnd.sun.xml.writer)
2007-12-05 21:26 UTC, kami911
no flags Details
TestCaseSpecification (8.49 KB, text/html)
2009-06-19 08:35 UTC, oc
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description kami911 2005-05-19 10:35:47 UTC
If you click on left side of statusbar (where is Page 1/3 text) in Writer You
can reach the Navigator. If you click on left side of statusbar (where is Sheet
1/3 text) in Calc  You can't reach the Navigator. It may be a bug? Isn't it?
Comment 1 frank 2005-06-13 13:31:03 UTC
It isn't.

Writer is special case. Calc isn't page oriented but Writer is, so the Navigator
opens as you can easily navigate the pages with it. Calc is Sheet based and
therefore each Sheet is rechable by it's sheettab.

Nvertheless I re-assign this to the requirements team as enhancement request.

Frank
Comment 2 kami911 2005-06-14 19:09:28 UTC
Navigator in Calc as use ful as in Writer :o) Same element in different part of
OOo should work as in others...
Comment 3 kami911 2006-02-09 23:26:50 UTC
Can someone hep out where can I found this part in the Writer?
Comment 4 kami911 2006-02-10 12:19:35 UTC
Hello fans!
sc\source\ui\view\tabvwsh3.cxx
has this lines:
		case SID_STATUS_DOCPOS:
			{
				//!	Navigator an-/ausschalten (wie im Writer) ???
				//!GetViewData()->GetDispatcher().Execute( SID_NAVIGATOR,
				//!						  SFX_CALLMODE_SYNCHRON|SFX_CALLMODE_RECORD );
			}
			break; 
it is very same in Writer:
sw\source\ui\uiview\view2.cxx
		case FN_STAT_PAGE:
		{
			GetViewFrame()->GetDispatcher()->Execute( SID_NAVIGATOR,
									  SFX_CALLMODE_SYNCHRON|SFX_CALLMODE_RECORD );
		}
		break;

Does anyone know anything why we not uncomment these lines in the Calc's source?
Comment 5 kami911 2006-02-10 12:25:37 UTC
timar -> for FSF.hu build
Comment 6 kami911 2006-02-10 12:55:46 UTC
Created attachment 34046 [details]
Patch to enable Navigator from statusbar - I will test it in my builds
Comment 7 frank 2006-02-10 13:04:10 UTC
Hi,

if you want this integrated, please write a small specification and get the
approval for it from QA, Development and User Experience.

Frank
Comment 8 kami911 2006-02-10 18:12:41 UTC
Created attachment 34056 [details]
draf version of specification - I hope it is enough :o)
Comment 9 lohmaier 2006-02-14 01:00:29 UTC
I guess it is OK, although it only consists of an abstract. 

Please post to dev@specs.openoffice.org to get some people to approve it (or let
them point out what is missing). Exp. I doubt that the people will accept you as
representative of User-Experience, but why not give it a try :-)

And it not reenabling the stuff (it was commented out from the very beginning..)

PS: Did you know OOo has a spell-checker? <evil grin/>
Comment 10 frank.loehmann 2006-03-13 14:25:48 UTC
FL-kami_: I really appreciate your work to get this change into the product. I
think this change is reasonable, but unfortunately the current specification is
incomplete and ambiguous.

 The "Abstract" section of a spec. has to contain just an abstract of the
content not the detailed solution. The abstract gives the reader an idea about
the content. Furthermore this section will be automatically processed to
generate a What's New Guide, to document changes made in a version. The spec.
should be added to the specs.openoffice.org project  to be processed for the
guide and it makes it easier to change something in the spec. without the need
to create a new attachment, when the sec. is just linked to the issue and vice
versa.
So please add a "Detailed Specification" part to the specification and describe
the solution/change in this part. I.e. adding a screenshot of the status bar
with a marked  double click area makes the description more unambiguous.
Comment 11 frank.loehmann 2006-03-13 14:31:03 UTC
Added myself to cc list.
Comment 12 kyoshida 2007-11-19 14:49:36 UTC
So, is the only thing holding this patch back is the spec?
Comment 13 kami911 2007-12-01 15:26:27 UTC
Kohei -> Would you review the patch and fix it if you need? Also I have created
a full spec. with more goals. I posted it to UX team. I will attach here If you
want.
Comment 14 kyoshida 2007-12-03 04:04:17 UTC
@kami_: sorry I didn't get back to you earlier.  I tested your patch, but merely
uncommenting those line will not launch the navigator by double-clicking the
sheet status area.  The code path never reaches there.

This means two things:

1) that SID_STATUS_DOCPOS block can be safely removed for the sake of code
cleanup. :-)

2) find another way to launch the navigator. (yikes!)

Kohei
Comment 15 kyoshida 2007-12-05 21:16:47 UTC
Created attachment 50134 [details]
patch that works
Comment 16 kyoshida 2007-12-05 21:17:13 UTC
setting issue type to PATCH.
Comment 17 kyoshida 2007-12-05 21:19:05 UTC
It turns out that the .uno:StatusDocPos command gets dispatched to
ScCellShell::Execute, not ScTabViewShell::Execute.  So you have to put the
handler code there to make it work.
Comment 18 kyoshida 2007-12-05 21:20:25 UTC
re-assigning it to nn so the issue won't get lost.
Comment 19 kyoshida 2007-12-05 21:23:42 UTC
Created attachment 50135 [details]
a little cosmetic change to make it look more blended in.
Comment 20 kami911 2007-12-05 21:26:09 UTC
Created attachment 50136 [details]
Draft specification for statusbar behaviors - passed to UX list
Comment 21 kami911 2007-12-09 15:32:48 UTC
nn: Can you integrate the Kohei's patch. I think the best way to open new issue
for the advised other changes.

KAMI 
Comment 22 niklas.nebel 2009-04-22 18:33:45 UTC
I added the patch, for the navigator on the sheet number field, to CWS "dr68".

There's issue 99730 about right-click on the page styles.
Comment 23 niklas.nebel 2009-05-19 09:14:50 UTC
reassigning to QA for verification
Comment 24 oc 2009-06-19 08:35:54 UTC
Created attachment 63081 [details]
TestCaseSpecification
Comment 25 oc 2009-06-19 08:45:04 UTC
verified in onternal build cws_dr68
Comment 26 amy2008 2009-07-31 03:30:17 UTC
Verified in DEV300m53 on WinXP
Closing