Issue 49422 - --with-build-version and C2015: too many characters in a constant
Summary: --with-build-version and C2015: too many characters in a constant
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P4 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: pavel
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-17 22:33 UTC by pavel
Modified: 2006-09-04 08:24 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
C2015: screenshot (27.65 KB, image/png)
2005-05-17 22:33 UTC, pavel 		no flags Details
Patch for sfx2/source/dialog/makefile.mk (1.16 KB, patch)
2005-06-04 16:10 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-05-17 22:33:29 UTC 
Hi,

I tried to use ./configure --with-build-version="Build-2 (Sun May 15 23:23:17
CEDT 2005)" and the build on Windows failed with:

e:\home\pavel\BuildDir\ooo_SRC680_m103_src\sfx2\source\dialog\about.cxx(240) :
error C2015: too many characters in constant

See the attached screenshot from rdesktop.
Comment 1 pavel 2005-05-17 22:33:55 UTC 
Created attachment 26252 [details]
C2015: screenshot
Comment 2 pavel 2005-05-17 22:34:27 UTC 
build on GNU/Linux with gcc 3.4.1 was OK.
Comment 3 mmeeks 2005-05-18 11:28:24 UTC 
Looks like the problem may well be that it's treating this as 'sdfsdfsfsd' ie.
as a character literal instead of binning the ''s and treating the (quoted)
string literal as a string.

Unfortunately - the quoting behavior is acutely unpleasant - tricky, nasty, etc.
I suggest that any chance is conditional on Win32 - quite possibly a different
quoting style in the makefile.mk would work well there.

HTh.
Comment 4 quetschke 2005-05-18 14:28:05 UTC 
> Unfortunately - the quoting behavior is acutely unpleasant - tricky, nasty, etc.
> I suggest that any chance is conditional on Win32 - quite possibly a different
> quoting style in the makefile.mk would work well there.
Nah, I just goofed a bit in guw.pl ;) I knew that my handling of quoted strings
in guw needed an overhaul but it didn't trigger any bug so far.
Comment 5 quetschke 2005-06-04 16:01:51 UTC 
No, guw.pl is not guilty, the "$%&$ MS compiler is the problem.

I don't know where they are hiding the information about quoting in
command files (@-files) for cl.exe, but I didn't find it :(

After some experiments I found that quoting with ' is not supported, " is
supported. So to get something like "String with space" into MYMACRO one *has*
to use
  -DMACRO="\"String with space\""
.
Comment 6 quetschke 2005-06-04 16:10:21 UTC 
Created attachment 26880 [details]
Patch for sfx2/source/dialog/makefile.mk
Comment 7 quetschke 2005-06-04 16:12:08 UTC 
The first hunk of the previous patch is the actual patch, the second is only a
clean-up.

Pavel can you test it?
Comment 8 pavel 2005-06-04 21:59:55 UTC 
Sure - works OK.
Comment 9 quetschke 2005-06-07 01:26:15 UTC 
Committed to vq17.
Comment 10 quetschke 2005-06-07 01:26:56 UTC 
vq->pjanik: Please verify.
Comment 11 pavel 2005-06-08 20:51:00 UTC 
verified
Comment 12 pavel 2005-06-08 20:51:16 UTC 
verified
Comment 13 pavel 2006-09-04 08:24:02 UTC 
closing.