Issue 47107 - "replace" suggestion string in thesaurus shows bracket ")"
Summary: "replace" suggestion string in thesaurus shows bracket ")"
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: Website general issues (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: issues@lingucomponent
QA Contact: issues@lingucomponent
URL:
Keywords:
: 48406 48407 (view as issue list)
Depends on:
Blocks: 44904
  Show dependency tree
 
Reported: 2005-04-10 13:57 UTC by ooolist2007
Modified: 2013-02-24 20:34 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
untested patch (689 bytes, patch)
2005-04-16 23:30 UTC, ooolist2007 		no flags Details | Diff
corrected patch (685 bytes, patch)
2005-04-17 22:52 UTC, ooolist2007 		no flags Details | Diff
thesau01 is ok -> see screenshot (115.76 KB, image/jpeg)
2005-04-28 19:22 UTC, eric.bachard 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ooolist2007 2005-04-10 13:57:18 UTC 
Open the thesaurus, type "walk" in the "Replace" box and click the "Search" 
button. The "Replace" box will then contain ") walking". It seems to be 
confused by the parentheses in "(noun)" that are part of the meanings now.
Comment 1 ooolist2007 2005-04-10 14:09:31 UTC 
Furthermore, only the first pair of parentheses is removed, so if a synonym is 
"(noun) vehicle (generic term)", the "Replace" field says ") vehicle (generic 
term)".
Comment 2 ooolist2007 2005-04-16 23:30:38 UTC 
Created attachment 25135 [details]
untested patch
Comment 3 ooolist2007 2005-04-16 23:32:09 UTC 
I attached a patch which I can't test because of general build problems. It's 
very simple, it only affects one file so I'd be glad if someone can test it.
Comment 4 maison.godard 2005-04-17 20:52:15 UTC 
The diff should be modified as the erase second argument is a length, not a position

            //rText.Erase( nPos, nEnd );
            rText.Erase( nPos, nEnd-nPos+1 ); 

tested on m92, seems to work

Laurent
Comment 5 ooolist2007 2005-04-17 22:52:24 UTC 
Created attachment 25151 [details]
corrected patch
Comment 6 eric.bachard 2005-04-20 21:12:43 UTC 
fixed in thesau01

-- 
eric bachard
Comment 7 eric.bachard 2005-04-28 19:22:57 UTC 
Created attachment 25622 [details]
thesau01 is ok -> see screenshot
Comment 8 eric.bachard 2005-04-28 19:24:36 UTC 
Hi,

Change seems to be ok.  Verified on Mac OSX, with m95 and m97.
-> see attached image.

-- 
eric bachard
Comment 9 maison.godard 2005-04-28 19:58:19 UTC 
ok for me also on debian m95

Laurent
Comment 10 eric.bachard 2005-04-28 20:41:24 UTC 
Verified on linux PPC too : m96 + j2sdk142/ debian sid
Comment 11 maison.godard 2005-04-29 08:13:19 UTC 
setting to verified
Comment 12 stefan.baltzer 2005-04-29 12:03:07 UTC 
SBA: Note: This seems to affect the "MySpell" dictionaries only. StarOffice does
not have this problem.

I strongly recommend to build a Windows CWS too (as the policies demand). Just
in case this patch DOES affect Windows in a negative way, we might easily run
into a P1 issue after that CWS gets integrated (i.e. if the linguistic decides
to crash on every office start). 

Personal note: I am not a passionate pessimist, but doing QA for years now
taught me that "thinking too positive" (as SOME developers do :-) backfires
"more often than never" :-)
Comment 13 ooolist2007 2005-04-29 19:15:27 UTC 
SBA: MySpell is only for spelling, the thesaurus dictionaries are independent 
from that. But StarOffice isn't affected, that's correct. I hope someone of 
you can do a Windows build, I cannot.
Comment 14 quetschke 2005-05-01 17:11:21 UTC 
Verified that the requested Windows build also works as desired.
Comment 15 stefan.baltzer 2005-05-02 15:32:59 UTC 
*** Issue 48407 has been marked as a duplicate of this issue. ***
Comment 16 eric.bachard 2005-06-17 20:30:26 UTC 
closed
Comment 17 ooolist2007 2005-08-15 14:33:41 UTC 
*** Issue 48406 has been marked as a duplicate of this issue. ***