Issue 46963 - Japanese can not input in OOo 2.0 for MacOSX
Summary: Japanese can not input in OOo 2.0 for MacOSX
Status: CLOSED DUPLICATE of issue 25416
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: OOo 2.0 Beta
Hardware: Mac Mac OS X, all
: P4 Trivial (vote)
Target Milestone: not determined
Assignee: maho.nakata
QA Contact: issues@porting
URL:
Keywords: oooqa
: 44528 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-04-07 16:11 UTC by usamik
Modified: 2008-05-17 23:54 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for x11osx/osxlocale.c (3.39 KB, patch)
2005-04-08 09:22 UTC, ekato 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description usamik 2005-04-07 16:11:43 UTC 
I tried to use OOo 2.0 for Mac OS X (1.9.m88), but Japanese can not input. I can
input Japanese in OOo 1.1.4 for Mac OS X.

It is guessed that the following patch is necessary. 
http://www.openoffice.org/nonav/issues/showattachment.cgi/15496/osxlocale.c-040527.diff
(Issue 27945)
Comment 1 ekato 2005-04-08 08:13:30 UTC 
We should update osxlocale.c with the one used in OOo 1.1.4.
The above patch only fixes Japanese, but Kevin's osxlocale.c
(existed in OOo 1.1.4) can fixes locale setting of any language.
Comment 2 maho.nakata 2005-04-08 08:56:58 UTC 
ekato:
could you please attach complete osxlocale.c patch for m91?
Comment 3 ekato 2005-04-08 09:22:59 UTC 
Created attachment 24826 [details]
Patch for x11osx/osxlocale.c
Comment 4 maho.nakata 2005-04-09 03:59:41 UTC 
ericb : could you please take over?
now it is your turn to create cws :)
Comment 5 eric.bachard 2005-04-09 13:20:41 UTC 
Euh... Do I again declare an older issue as duplicated ?  
Why didn't you use  #i44528#  ?

-- 
eric bachard
Comment 6 maho.nakata 2005-04-10 03:14:55 UTC 
reassign to maho
Comment 7 maho.nakata 2005-04-10 03:17:37 UTC 
ericb2 : sorry for this time, but attached patch seems to be better than
#i44528#
Comment 8 maho.nakata 2005-04-10 03:18:57 UTC 
*** Issue 44528 has been marked as a duplicate of this issue. ***
Comment 9 maho.nakata 2005-04-10 03:19:54 UTC 
set target milestone
Comment 10 maho.nakata 2005-04-10 03:37:10 UTC 
sorry i forgot say thanks for ekato
thank you very much for providing a patch!
Comment 11 thorsten.ziehm 2005-04-11 16:56:00 UTC 
.
Comment 12 maho.nakata 2005-04-12 01:39:45 UTC 
install sets of 1.9m92 with x11osx/osxlocale.c patch applied
are available at:
ftp://ooopackages.good-day.net/pub/OpenOffice.org/MacOSX/1.9m92/
MD5 (OOo_1.9m92_MacOSXPowerPC_install_en-US.tar.bz2) =
bbc08482afa01aed28ccb0c70bf3ae24
MD5 (OOo_1.9m92_MacOSXPowerPC_install_ja.tar.bz2) = 5c6e60e0441c6ce5ba924b4f24ae3570

asari, ekato, ericb, usamik : could you please these installation
set and comment?
Comment 13 maho.nakata 2005-04-12 01:40:00 UTC 
.
Comment 14 usamik 2005-04-14 01:05:13 UTC 
maho : thank you for your work.
I try to run this build, but it does not run.

run in xterm
 % /Applications/openoffice.org1.9.92/program/swriter
display logo, and exit application.
Comment 15 maho.nakata 2005-04-15 03:13:05 UTC 
lower prio.
Comment 16 eric.bachard 2005-05-06 01:18:30 UTC 
ericb -> ekato 

Looking at your patch, I wonder if it's really kCFStringEncodingASCII ? (see above)

Why isn't it kCFStringEncodingUTF8,for Panther (and later) ?


@@ -132,6 +115,28 @@
           fprintf( stderr, "Could not get value of CFPref AppleLanguages! 
Please reset your locale in the International control panel.\n" );
 
 	return( noErr );
+
+#else 
+// Panther and later code
+
+        CFStringRef lstr;
+        CFLocaleRef lref;
+
+        lref = CFLocaleCopyCurrent();
+        lstr = CFLocaleGetIdentifier(lref);
+        CFStringGetCString(lstr, locale, bufferLen, kCFStringEncodingASCII);

...
Comment 17 ekato 2005-05-06 04:28:33 UTC 
ekato -> ericb

Since locale string returned by CFLocaleGetIdentifier() is always within ascii
characters (like "en_US"), kCFStringEncodingASCII is enough, I think.
Comment 18 tino.rachui 2005-06-27 08:30:11 UTC 
.

*** This issue has been marked as a duplicate of 25416 ***
Comment 19 ace_dent 2008-05-17 21:50:25 UTC 
The Issue you raised has been marked as 'Resolved' and not updated within the
last 1 year+. I am therefore setting this issue to 'Verified' as the first step
towards Closing it. If you feel this is incorrect, please re-open the issue and
add any comments.

Many thanks,
Andrew
 
Cleaning-up and Closing old Issues
~ The Grand Bug Squash, pre v3 ~
http://marketing.openoffice.org/3.0/announcementbeta.html
Comment 20 ace_dent 2008-05-17 23:54:41 UTC 
As per previous posting: Verified -> Closed.
A Closed Issue is a Happy Issue (TM).

Regards,
Andrew