Hi,

while building mozooo cws (1.7.5) on MacOS X, the build fails with
g++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall 
-Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual 
-Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long 
-fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -pipe  
-DNDEBUG -DTRIMMED -O  -DXTHREADS -I/opt/local/include/gtk-2.0 
-I/opt/local/lib/gtk-2.0/include -I/opt/local/include/atk-1.0 
-I/opt/local/include/pango-1.0 -I/opt/local/include 
-I/opt/local/include/freetype2 -I/usr/X11R6/include 
-I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include   
-fPIC -arch ppc -o libgfx_gtk.dylib  nsPrintdGTK.o gtk2drawing.o 
nsDeviceContextGTK.o nsDeviceContextSpecFactoryG.o 
nsDeviceContextSpecG.o nsDrawingSurfaceGTK.o nsGfxFactoryGTK.o 
nsGraphicsStateGTK.o nsImageGTK.o nsGCCache.o 
nsRenderingContextGTK.o nsScreenGtk.o nsScreenManagerGtk.o 
nsPrintOptionsGTK.o nsFontMetricsUtils.o nsAntiAliasedGlyph.o 
nsFontFreeType.o nsFT2FontNode.o nsFT2FontCatalog.o 
nsX11AlphaBlend.o nsXFontAAScaledBitmap.o nsXFontNormal.o 
nsFontMetricsGTK.o nsGdkUtils.o nsRegionGTK2.o nsNativeThemeGTK.o  
nsFreeType.o     -Wl,-exported_symbols_list 
-Wl,../../../build/unix/gnu-ld-scripts/components-export-list 
-bundle -L../../../dist/bin -lxpcom -L../../../dist/bin 
-L/Volumes/Daten/OpenOffice/680_m58/moz/unxmacxp.pro/misc/build/mozilla/dist/lib 
-lplds4 -lplc4 -lnspr4 -lpthread  -lgkgfx -lgfxshared_s  
-L../../../dist/bin -lmozjs ../../../dist/lib/libunicharutil_s.a    
-L/opt/local/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 
-lgdk_pixbuf-2.0 -ltiff -ljpeg -lpng12 -lz -lm -lpangoxft-1.0 
-lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 
-lintl -liconv   -lm    
ld: nsDeviceContextGTK.o illegal reference to symbol: _XGetOMValues 
defined in indirectly referenced dynamic library 
/usr/X11R6/lib/libX11.6.dylib
ld: warning multiple definitions of symbol _locale_charset
/opt/local/lib/libintl.dylib(localcharset.o) definition of 
_locale_charset
/opt/local/lib/libiconv.dylib(localcharset.o) definition of 
_locale_charset
make[4]: *** [libgfx_gtk.dylib] Error 1
make[3]: *** [libs] Error 2
make[2]: *** [libs] Error 2
make[1]: *** [tier_9] Error 2
make: *** [default] Error 2
dmake:  Error code 2, while making 
'./unxmacxp.pro/misc/build/so_built_ooo_mozab'
'---* tg_merge.mk *---'

(see Eric Hoch's report about this at
http://porting.openoffice.org/servlets/ReadMsg?list=dev&msgNo=14572).

The problem is missing -lX11 on the command line. It seems to be needed only on
Mac OS X.

The attached patch to mozoo's mozilla-1.7.5.patch fixes the problem. it is safe
because it is only for Darwin.