Issue 41626 - mozooo: Use DLLPOST and DLLPRE
Summary: mozooo: Use DLLPOST and DLLPRE
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wind.li
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-30 13:19 UTC by pavel
Modified: 2005-08-19 06:28 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Use DLLPRE and DLLPOST instead of own magic. (4.54 KB, patch)
2005-01-30 18:20 UTC, pavel 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-01-30 13:19:45 UTC 
Hi,

current extensionfiles.mk contains:

# LINRARY_FILENAME=$(LIB_PREFIX)$(NAME_BODY).$(LIB_EXTENSION)
# For example:xpcom in unix is (lib)xpcom(.)(so), in win32 is ()xpcom(.)(dll)
.IF "$(GUI)"=="WNT"
LIB_PREFIX=
LIB_EXTENSION=dll
.ELSE   #"$(GUI)"=="WNT"
LIB_PREFIX=lib
LIB_EXTENSION=so
.ENDIF

This is a duplicated (and not complete) rework of DLLPOST and DLLPRE from e.g.
inc/wnt.mk and similar environmental files. Please use already provided system,
because otherwise you are breaking e.g. MacOS X builds.
Comment 1 pavel 2005-01-30 18:19:23 UTC 
I'll attach sample patch. It contains one invalid change: I'm cheating on MacOS
X and I do not use GNU cp -> I have to remove -L argument.
Comment 2 pavel 2005-01-30 18:20:01 UTC 
Created attachment 22013 [details]
Use DLLPRE and DLLPOST instead of own magic.
Comment 3 pavel 2005-01-30 18:20:30 UTC 
set target.
Comment 4 wind.li 2005-01-31 04:52:09 UTC 
verifed on linux and solaris
Comment 5 eric_openoffice 2005-01-31 08:12:18 UTC 
The patch at least partially fails when applying it on Mac OS X.

The error message I get is:
[Maveric:680_m71/build/moz] maveric% patch -p0 <
/Volumes/Daten/OpenOffice/680_m71/patches/moz_build/mozooo-macosx_dylib.diff 
patching file extractfiles.mk
Hunk #6 FAILED at 275.
1 out of 8 hunks FAILED -- saving rejects to file extractfiles.mk.rej

If anyones interested I can attach the extractfiles.mk.rej or send it via
private Mail.
Comment 6 wind.li 2005-01-31 08:21:30 UTC 
It is maybe based on a old version. I had checked in it. So you can use cvs
update to get it.
Comment 7 pavel 2005-01-31 13:47:08 UTC 
looks likewe can also mark this as FIXED too. Right?
Comment 8 wind.li 2005-01-31 13:57:58 UTC 
set to fixed
thanks
Comment 9 Frank Schönheit 2005-02-28 15:29:04 UTC 
to me this looks like the patch made it into the CWS' CVS ..
Comment 10 Martin Hollmichel 2005-08-19 06:28:34 UTC 
close issue.