Issue 41163 - edit look/www/overrides/templates/PreServlet.vm to make it valid XHTML
Summary: edit look/www/overrides/templates/PreServlet.vm to make it valid XHTML
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: Website general issues (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stx123
QA Contact: issues@www
URL:
Keywords:
Depends on:
Blocks: 7294
  Show dependency tree
 
Reported: 2005-01-23 23:45 UTC by lohmaier
Modified: 2005-02-05 06:58 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
the updated PreServlet.vm for your convenience (1.91 KB, text/plain)
2005-01-23 23:46 UTC, lohmaier 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lohmaier 2005-01-23 23:45:28 UTC 
Currently, the automatically added body tags prevent OOo pages from being valid
XHTML-transitional.
The reason for this are non-defined attributes "marginwidth" and marginheight

From w3c-validator:
#####
Line 43, column 40: there is no attribute "marginwidth"

<body onload="loginfocus()" marginwidth="0" marginheight="0" class="composite">

You have used the attribute named above in your document, but the document type
you are using does not support that attribute for this element. This error is
often caused by incorrect use of the "Strict" document type with a document that
uses frames (e.g. you must use the "Transitional" document type to get the
"target" attribute), or by using vendor proprietary extensions such as
"marginheight" (this is usually fixed by using CSS to achieve the desired effect
instead). [...]
######

This diff will fix the problem:
$ cvs diff PreServlet.vm
Index: PreServlet.vm
===================================================================
RCS file: /cvs/look/www/overrides/templates/PreServlet.vm,v
retrieving revision 1.1
diff -r1.1 PreServlet.vm
17c17
< <body onload="loginfocus()" marginwidth="0" marginheight="0" class="composite">
---
> <body onload="loginfocus()" class="composite">
Comment 1 lohmaier 2005-01-23 23:46:05 UTC 
Created attachment 21790 [details]
the updated PreServlet.vm for your convenience
Comment 2 lohmaier 2005-01-23 23:49:07 UTC 
If this issue and issue 41162 will be fixed, we can proudly use one of the "this
page is valid XHTML"-Buttons :-)
Comment 3 stx123 2005-01-26 11:58:02 UTC 
Hi, I tried it with
http://website.openoffice.org/tryouts/st/hometest/index.html
It looks good and I would like to proceed with Christian's change.
Louis, any objections?
Greetings, Stefan
Comment 4 lsuarezpotts 2005-01-26 17:18:21 UTC 
Not from me--thanks Christian!
My only concern is that when we are upgraded we may lose these changes unless we save them.  (I 
hope by then CN will have fixed them in its template, too.)

Louis
Comment 5 stx123 2005-02-02 11:33:27 UTC 
Thanks Christian, I change the file according to your suggestions.
Please let me know, if something went wrong...
Comment 6 lohmaier 2005-02-04 19:39:24 UTC 
verifying.. fix is OK..

I only wonder whether it it necessary to have " -//Tigris//DTD XHTML 1.0
Transitional//EN" instead of "-//W3C//DTD XHTML 1.0 Transitional//EN"

- but this is probably is another issue...
Comment 7 lohmaier 2005-02-04 19:40:29 UTC 
original issue is fixed -> closing.
Comment 8 lsuarezpotts 2005-02-05 06:58:37 UTC 
Christian, 
I can ask about that, but my impression, from about two years ago, was, yes.  

Louis