Apache OpenOffice (AOO) Bugzilla – Issue 41163
edit look/www/overrides/templates/PreServlet.vm to make it valid XHTML
Last modified: 2005-02-05 06:58:37 UTC
Currently, the automatically added body tags prevent OOo pages from being valid XHTML-transitional. The reason for this are non-defined attributes "marginwidth" and marginheight From w3c-validator: ##### Line 43, column 40: there is no attribute "marginwidth" <body onload="loginfocus()" marginwidth="0" marginheight="0" class="composite"> You have used the attribute named above in your document, but the document type you are using does not support that attribute for this element. This error is often caused by incorrect use of the "Strict" document type with a document that uses frames (e.g. you must use the "Transitional" document type to get the "target" attribute), or by using vendor proprietary extensions such as "marginheight" (this is usually fixed by using CSS to achieve the desired effect instead). [...] ###### This diff will fix the problem: $ cvs diff PreServlet.vm Index: PreServlet.vm =================================================================== RCS file: /cvs/look/www/overrides/templates/PreServlet.vm,v retrieving revision 1.1 diff -r1.1 PreServlet.vm 17c17 < <body onload="loginfocus()" marginwidth="0" marginheight="0" class="composite"> --- > <body onload="loginfocus()" class="composite">
Created attachment 21790 [details] the updated PreServlet.vm for your convenience
If this issue and issue 41162 will be fixed, we can proudly use one of the "this page is valid XHTML"-Buttons :-)
Hi, I tried it with http://website.openoffice.org/tryouts/st/hometest/index.html It looks good and I would like to proceed with Christian's change. Louis, any objections? Greetings, Stefan
Not from me--thanks Christian! My only concern is that when we are upgraded we may lose these changes unless we save them. (I hope by then CN will have fixed them in its template, too.) Louis
Thanks Christian, I change the file according to your suggestions. Please let me know, if something went wrong...
verifying.. fix is OK.. I only wonder whether it it necessary to have " -//Tigris//DTD XHTML 1.0 Transitional//EN" instead of "-//W3C//DTD XHTML 1.0 Transitional//EN" - but this is probably is another issue...
original issue is fixed -> closing.
Christian, I can ask about that, but my impression, from about two years ago, was, yes. Louis