Issue 36160 - GCC "visibility" feature: need feature test instead of version test
Summary: GCC "visibility" feature: need feature test instead of version test
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: matthias.huetsch
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 36052
  Show dependency tree
 
Reported: 2004-10-26 18:26 UTC by matthias.huetsch
Modified: 2013-08-07 15:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description matthias.huetsch 2004-10-26 18:26:52 UTC 
Summary says it all: don't test for GCC version, but for feature availability. i.e.

#if (_GCC_MAJOR >= 3) && (_GCC_MINOR >= 4)
...
#endif

needs to be changed into something like

#if defined(HAVE_GCC_VISIBILITY_FEATURE)
...
#endif

This applies to 'sal/inc/sal/types.h' as well as the makefiles where this is (to
be) used (currently: 'sw/inc/sw.mk', 'sc/util/makefile.pmk', 'sd/util/makefile.mk').

The 'HAVE_GCC_VISIBILITY_FEATURE' needs then be 'configure'd (see issue 36052,
which depends on this one).
Comment 1 matthias.huetsch 2004-10-26 18:29:53 UTC 
Accepting...
Comment 2 matthias.huetsch 2004-10-26 18:34:44 UTC 
Adding Ken and Ause to CC...
Comment 3 matthias.huetsch 2004-10-27 15:18:19 UTC 
Fixed in 'solenv/inc/unxlngi{4,5,6}.mk', 'sal/inc/sal/types.h',
'sc/util/makefile.pmk', 'sd/util/makefile.pmk', and 'sw/inc/sw.mk' on
cws_src680_gccvisibilityfix.
Comment 4 matthias.huetsch 2004-10-27 15:20:41 UTC 
Environment variable 'HAVE_GCC_VISIBILITY_FEATURE' set by (Hamburg internal)
'setsolar.pl'.

'configure' will be adapted via issue 36052.

Code reviewed (developer / tools task) => verified.
Comment 5 matthias.huetsch 2004-11-14 17:30:57 UTC 
Fix integrated into milestone 680m60 (alias 1.9.m60) => closing.