Issue 32707 - binfilter: `acquire' undeclared (first use this function)
Summary: binfilter: `acquire' undeclared (first use this function)
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Armin Le Grand
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-07 10:34 UTC by pavel
Modified: 2004-09-08 16:53 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-08-07 10:34:49 UTC 
Hi,

while compiling bf_xmloff/source/chart/xmloff_SchXMLAutoStylePoolP.cxx in
SRC680_m50:

In file included from ../../../inc/bf_xmloff/SchXMLExport.hxx:65,
                 from
/home/oo/BuildDir/ooo_SRC680_m50_src/binfilter/bf_xmloff/source/chart/xmloff_SchXMLAutoStylePoolP.cxx:65:
../../../inc/bf_xmloff/uniref.hxx: In copy constructor
`binfilter::UniReference<T>::UniReference(const binfilter::UniReference<T>&)
[with T = binfilter::XMLPropertySetMapper]':
../../../inc/bf_xmloff/SchXMLExportHelper.hxx:207:   instantiated from here
../../../inc/bf_xmloff/uniref.hxx:168: error: `acquire' undeclared (first use
this function)
../../../inc/bf_xmloff/uniref.hxx:168: error: (Each undeclared identifier is
reported only once for each function it appears in.)
../../../inc/bf_xmloff/uniref.hxx: In destructor
`binfilter::UniReference<T>::~UniReference() [with T =
binfilter::XMLPropertySetMapper]':
../../../inc/bf_xmloff/SchXMLExportHelper.hxx:207:   instantiated from here
../../../inc/bf_xmloff/uniref.hxx:175: error: `release' undeclared (first use
this function)
dmake:  Error code 1, while making
'../../../unxlngi4.pro/slo/xmloff_SchXMLAutoStylePoolP.obj'
---* tg_merge.mk *---

ERROR: Error 65280 occurred while making
/home/oo/BuildDir/ooo_SRC680_m50_src/binfilter/bf_xmloff/source/chart
Comment 1 mci 2004-08-09 08:37:39 UTC 
Hi pjanik,

thanks for using and supporting OpenOffice.org...

-----------
reassigned to aw

mci->aw: Hi aw, this seems to be something for you, too...
Comment 2 pavel 2004-08-11 22:37:30 UTC 
This fixed it, but it is not correct solution, surely:

--- uniref.hxx.~1.2.~	2003-12-05 10:18:03.000000000 +0100
+++ uniref.hxx	2004-08-11 22:16:19.000000000 +0200
@@ -164,15 +164,11 @@
 inline UniReference< T >::UniReference( const UniReference< T > & rRef )
 	: mpElement( rRef.mpElement )
 {
-	if( mpElement )
-		mpElement->acquire();
 }
 
 template< class T >
 inline UniReference< T >::~UniReference()
 {
-	if( mpElement )
-		mpElement->release();
 }
 
 /**
Comment 3 pavel 2004-08-13 15:34:43 UTC 
I use gcc version 3.3.1 (SuSE Linux) on the build machine (SL9.0).
Comment 4 rodarvus 2004-08-13 15:37:39 UTC 
The following seems to correct this build error:

Index: xmloff_SchXMLAutoStylePoolP.cxx
===================================================================
--- xmloff_SchXMLAutoStylePoolP.cxx     (revision 59)
+++ xmloff_SchXMLAutoStylePoolP.cxx     (revision 60)
@@ -58,6 +58,9 @@
  *
  *
  ************************************************************************/
+
+#include <xmlprmap.hxx>
+
 // auto strip #include "SchXMLAutoStylePoolP.hxx"
 #include "PropertyMap.hxx"
Comment 5 pavel 2004-08-20 20:29:42 UTC 
set target, raising prio, because this is build issue.
Comment 6 foskey 2004-08-22 13:53:49 UTC 
Confirming error currently on HEAD,  see tinderbox http://ooo.ximian.com
Comment 7 foskey 2004-08-27 15:27:14 UTC 
Confirming patch by rodarvus works correctly.
Comment 8 pavel 2004-08-27 22:26:42 UTC 
changing type to patch.

hr: could you please commit it to some branch so it is on HEAD soon?
Comment 9 pavel 2004-08-30 19:59:44 UTC 
Fixed in cws pj01.
Comment 10 jens-heiner.rechtien 2004-08-31 14:12:32 UTC 
Verified
Comment 11 pavel 2004-09-08 16:53:51 UTC 
Closing.