Issue 3233 - Trailing tabs in input fields ignored
Summary: Trailing tabs in input fields ignored
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 642
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 3232
  Show dependency tree
 
Reported: 2002-02-27 14:53 UTC by caolanm
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
allow trailing tabs in input (etc) fields (527 bytes, patch)
2002-02-27 14:54 UTC, caolanm 		no flags Details | Diff
sample .sxw file (5.15 KB, application/octet-stream)
2002-02-27 14:55 UTC, caolanm 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2002-02-27 14:53:36 UTC 
Input fields can contain tabs, and they are drawn and positioned correctly,
unless they are the last character in the field, in which case they are ignored.
A document to demoonstrate attached.

Ideally the tabstops would be honoured despite being the last character. The
attached patch makes it work, though whether it is fully correct or not is
another issue. 

If fields could contain a trailing tabstop, then an additional patch could be
used to fix a long outstanding msword list import layout issue. (in issue
blocked by this)
Comment 1 caolanm 2002-02-27 14:54:27 UTC 
Created attachment 1101 [details]
allow trailing tabs in input (etc) fields
Comment 2 caolanm 2002-02-27 14:55:01 UTC 
Created attachment 1102 [details]
sample .sxw file
Comment 3 frank.meies 2002-02-27 16:51:41 UTC 
FME->CMC: Having a first look at your patch I am tempted to say that
the line "if(aNew.Len())" possibly could be deleted. Your patch for
issue 3233 look also quite good. But any changes here surely need more
than a first look. So I'll discuss this with AMA as soon as he's back.
Comment 4 caolanm 2002-02-27 17:58:51 UTC 
cmc->fme: Most excellent. This issue is just to soften you up for the
other idea. If I can sell a chain of reasoning of, tabs in fields ok
-> tabs at end of fields ok -> numbering can have a tab at the end ok,
then my cunning master plan can take shape.
Comment 5 frank.meies 2002-03-11 07:42:55 UTC 
There does not seem to be a special reason for not considering tab 
stops at the end of an input field.
Comment 6 frank.meies 2002-12-04 11:46:57 UTC 
FME->CMC: Do you agree if I set the target to OOo 2.0?
Comment 7 caolanm 2002-12-04 12:04:08 UTC 
Ok by me... coward :-)
Comment 8 frank.meies 2003-09-15 14:18:37 UTC 
FME: Fixed in cws os20.

FME: I also applied CMC's patch proposed for i3232.
Comment 9 frank.meies 2003-09-23 08:15:48 UTC 
.
Comment 10 michael.ruess 2003-09-24 10:30:56 UTC 
Fix checked with CWS os20.
Comment 11 michael.ruess 2003-09-24 10:31:47 UTC 
Verified.
Comment 12 michael.ruess 2004-03-25 14:40:46 UTC 
Checked integration in 680m30.