Issue 3130 - ooo1.0 ppc linux bridge code in OOO_STABLE_1 is old
Summary: ooo1.0 ppc linux bridge code in OOO_STABLE_1 is old
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: current
Hardware: Mac Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: khendricks
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-02-19 01:53 UTC by khendricks
Modified: 2002-03-06 23:41 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to update bridge/source/cpp_uno/gcc2_linux_powerpc to OO641C level (1.61 KB, application/octet-stream)
2002-02-19 01:55 UTC, khendricks 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description khendricks 2002-02-19 01:53:06 UTC 
ppc linux bridge/source/cpp_uno/gcc2_linux_powerpc code in OOO_STABLE_1 is old 
and incorrect.  More correct version ia in OO641C tree.

I will attach the patch to fix the issue below.
Comment 1 khendricks 2002-02-19 01:55:00 UTC 
Created attachment 1058 [details]
patch to update bridge/source/cpp_uno/gcc2_linux_powerpc to OO641C level
Comment 2 kay.ramme 2002-02-20 07:57:12 UTC 
Daniel, could you please approve this patch?
It will then be applied by Kevin and goes
into OOo stable build.
Comment 3 Daniel Boelzle [:dbo] 2002-02-20 16:37:11 UTC 
I trust your code, Kevin and cannot approve this issue, anyway.  We
don't have any linux power-pc machine here in Hamburg.  So as long as
this does not stop our internal builds (correct .IF statements in
makefile.mk), you have to test this by yourself.  And I am sure you
have already done while developing...
usual tests: compile the testcppu executable in cppu/test directory
and run it.  For more high-level office specific testing, try some
basic stuff (basic using corereflection using bridges).
Comment 4 khendricks 2002-02-21 01:08:52 UTC 
adding proper ooo1.0 keyword I should have put there first
Comment 5 Martin Hollmichel 2002-02-28 20:15:08 UTC 
reassigned to joerg
Comment 6 Martin Hollmichel 2002-02-28 20:17:10 UTC 
ok, I was too fast, first think then type
Comment 7 khendricks 2002-03-01 00:33:32 UTC 
Hi,

In case this helps.  This exact patch was in OO641C and in many 
other earlier release builds.  I konw because I had commit privs to 
the ppc Linux specific part of the bridge code (which this is).

It ONLY impacts the PPC Linux platform code and will not impact any
other platform.

Hope this helps,

Kevin
Comment 8 khendricks 2002-03-05 14:08:04 UTC 
Hi,

Any ruling on this patch yet.  I promise you it will not impact the 
build and has been in Oo641C and many earlier versions and only 
impact the ppc linux bridge code which I wrote based on the x86 
bridge code and lots of helpful hints from Hamburg.

Without this patch, the bridge code simply will not work and OOo can 
then not be used under ppc linux.

Please someone allow me to commit this patch.

Thanks,

Kevin
Comment 9 Martin Hollmichel 2002-03-05 14:18:51 UTC 
I think Daniel wanted to say that he always trust your code in this 
LinuxPPC dependent directory and is not able to test this.

From my point of view you don't need approval for this directory and
daniel (dbo@openoffice.org) will give advise for any bridges code 
whenever he is able to. Daniel, can you please give a statement to my 
assumption ?
Comment 10 Daniel Boelzle [:dbo] 2002-03-06 14:36:06 UTC 
Yes Martin, that's what I wanted to say:
@Kevin: Please check in your bridges linux ppc changes.  I trust you.
 Just wanted to point out that, nevertheless, I can't review/test it
nor is this necessary for our target platforms.
regards,

--Daniel
Comment 11 khendricks 2002-03-06 23:40:31 UTC 
Hi All,

Thanks!  I just did the commit to OOO_STABLE_1 so ppc linux is in 
good shape now in bridges.

Thanks again!

Kevin
Comment 12 khendricks 2002-03-06 23:41:00 UTC 
closing this one out.