Issue 30156 - Change switches of rsc with filename to -xx=<filename> syntax
Summary: Change switches of rsc with filename to -xx=<filename> syntax
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 680m41
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Martin Hollmichel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 29893
  Show dependency tree
 
Reported: 2004-06-13 15:01 UTC by quetschke
Modified: 2004-12-20 15:48 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for rsc/source/prj/ (2.25 KB, patch)
2004-06-13 15:03 UTC, quetschke 		no flags Details | Diff
Patch for rsc/source/rsc/ (3.37 KB, patch)
2004-06-13 15:03 UTC, quetschke 		no flags Details | Diff
Patch for rsc/source/parser/ (2.34 KB, patch)
2004-06-13 15:04 UTC, quetschke 		no flags Details | Diff
Patches for ?tg_srs.mk and ?tg_rslb.mk (29.62 KB, patch)
2004-06-13 15:06 UTC, quetschke 		no flags Details | Diff
Patch for rscdep.cxx (986 bytes, patch)
2004-06-14 18:48 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2004-06-13 15:01:12 UTC 
vq->ause, *: Please approve.

See issue 29893 for details. guw.pl needs to know exactly when the switch
ends and the filename starts. I did a complete build with the following
patches, please check if they collide with the internal hamburg environment.

P.S.: rsc/doku/feinkonz.43/rsc.doc is an old Starwriter document
(".\\\ WRITER 6 \\\ ") and imports really bad into OOo 1.1.1, but when
the patches are accepted I'd change the description there also and commit
it as OOo document.

Changed switches:
* rsc.exe
  -pp
  -fo
  -fp

* rsc2.exe
  -fs
  -lip
  -fp
  -fl
  -fh
  -fc
  -fr
  -fx
  -ft
  -oil

And solenv/inc where rsc was used.
Comment 1 quetschke 2004-06-13 15:03:11 UTC 
Created attachment 15864 [details]
Patch for rsc/source/prj/
Comment 2 quetschke 2004-06-13 15:03:54 UTC 
Created attachment 15865 [details]
Patch for rsc/source/rsc/
Comment 3 quetschke 2004-06-13 15:04:52 UTC 
Created attachment 15866 [details]
Patch for rsc/source/parser/
Comment 4 quetschke 2004-06-13 15:06:34 UTC 
Created attachment 15867 [details]
Patches for ?tg_srs.mk and ?tg_rslb.mk
Comment 5 quetschke 2004-06-14 18:47:35 UTC 
The build finished without error, but only because rscdep is missing any
error handling and rules.mk also doesn't break on a missing *.dprr file.

$(MISC)$/%.dpr section:
	dmake $(MFLAGS) $(MAKEFILE) $(CALLMACROS) NO_HIDS=true make_srs_deps=true
$(DEPSRSFILES)
	+-$(TYPE) $(MISC)$/$(PWD:f).*.dprr >> $@

The following patch for tools/bootstrp/rscdep.cxx should fix the problem.
Comment 6 quetschke 2004-06-14 18:48:39 UTC 
Created attachment 15893 [details]
Patch for rscdep.cxx
Comment 7 quetschke 2004-06-14 18:50:12 UTC 
I guess this is a tools issue ...
Comment 8 hjs 2004-06-15 11:41:12 UTC 
with a bit of headache (where are the side efects?) i approve... ;-)
Comment 9 quetschke 2004-06-15 21:39:50 UTC 
Committed to cws_src680_ooo20040620.
Comment 10 quetschke 2004-06-28 17:05:02 UTC 
Needs also to be fixed for cws_src680_ooo20040704.
Comment 11 quetschke 2004-06-29 18:31:58 UTC 
Crossmerged to cws_src680_ooo20040704.
Comment 12 Martin Hollmichel 2004-12-20 15:48:40 UTC 
close issue.