Issue 29514 - nswrapper: netscape vs. mozilla
Summary: nswrapper: netscape vs. mozilla
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1.3
Assignee: rene
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-26 09:51 UTC by pmladek
Modified: 2007-02-05 13:34 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
This patch fixes nswrapper to start mozilla instead of netscape. (472 bytes, patch)
2004-05-26 09:53 UTC, pmladek
no flags Details | Diff
This patch adds mozwrapper as a complement to nswrapper (it is against OOo, version 1.1.2) (2.54 KB, patch)
2004-08-03 10:12 UTC, pmladek
no flags Details | Diff
This patch avoid installation warning "File nswrapper not found." (548 bytes, patch)
2004-08-14 11:28 UTC, bluedwarf
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2004-05-26 09:51:52 UTC
First, I am sorry if this is a bad component.

There is isntalled the script nswrapper in OOo_HOME/program. I think that
mozilla is used more widely nowadays.

I will attach a patch which fixes the script to use mozilla instead of netscape.

In fact, I didn't find where the script is used in OOo sources. I do not know if
it is used used by some users. Maybe it could/should be removed at all.
Comment 1 pmladek 2004-05-26 09:53:20 UTC
Created attachment 15469 [details]
This patch fixes nswrapper to start mozilla instead of netscape.
Comment 2 thorsten.martens 2004-05-26 11:54:47 UTC
TM->MH: Please have a look, thanks !
Comment 3 Martin Hollmichel 2004-06-18 11:44:28 UTC
mh->obr: do you know if the script nswrapper is used anymore ?
Comment 4 nospam4obr 2004-06-19 10:20:42 UTC
The script has always been there as an example to be used from the "external
programs" tabpage, which I removed from the OOo 2.0 code base a couple of weeks
ago. So for OOo 2.0, this file can be removed.

For OOo 1.1.x it may be a better idea to install a second file for mozilla
instead of patching the original one.
Comment 5 nospam4obr 2004-07-02 13:58:21 UTC
So, will someone create a patch that creates a new wrapper script for mozilla
instead of patching the netscape one  ? Otherwise I will close this as WONTFIX.
Comment 6 nospam4obr 2004-07-08 09:44:15 UTC
obr @ pmladek: please rework the patch so that it creates a new file for
wrapping mozilla instead of patching the original one.
Comment 7 pmladek 2004-07-08 09:47:49 UTC
I am sorry. I am quite busy this week. I'll do it the following week.
Comment 8 pmladek 2004-08-03 10:12:25 UTC
Created attachment 16906 [details]
This patch adds mozwrapper as a complement to nswrapper (it is against OOo, version 1.1.2)
Comment 9 pmladek 2004-08-03 10:14:23 UTC
I have added the requested patch and will reassing the bug back to obr.
Comment 10 Martin Hollmichel 2004-08-03 10:57:37 UTC
mh->pmladek: are you able to commit yourself ? ooo113fix2 is open for commit at
the moment !
Comment 11 pmladek 2004-08-03 11:53:00 UTC
Ah, I cannot commit it. I do not have write access.
Comment 12 rene 2004-08-03 13:12:39 UTC
Hi Petr,

committed to cws_srx645_ooo113fix2.

Regards,

René
Comment 13 nospam4obr 2004-08-03 13:45:55 UTC
thanks for taking over.
Comment 14 rene 2004-08-03 14:00:44 UTC
Hi,

Hmm. And since this example files are useless in 2.0 as obr said, I just
committed the removal to cws_src680_ooo20040815. Issue fixed :-)

Regards,

René
Comment 15 bluedwarf 2004-08-14 11:28:36 UTC
Created attachment 17138 [details]
This patch avoid installation warning "File nswrapper not found."
Comment 16 bluedwarf 2004-08-14 11:39:20 UTC
When I built and installed cws_src680_ooo20040815, the installation program
warned me that it couldn't find "nswrapper". The removal caused this problem.
You should have also removed related things from ooo_file.scp.

Apply this patch to cws_src680_ooo20040815.

Regards,
Takashi Nakamoto (signed JCA)
Comment 17 Martin Hollmichel 2004-08-26 14:05:15 UTC
ok, reviewed for 113fix2, both scripts get installed now.
Comment 18 Martin Hollmichel 2004-08-26 16:17:33 UTC
verified.
Comment 19 Mathias_Bauer 2007-02-05 13:34:10 UTC
closing ancient issues