Apache OpenOffice (AOO) Bugzilla – Issue 29286
FreeBSD porting: deliver.pl needs strip command
Last modified: 2006-04-04 21:02:38 UTC
Porting to FreeBSD, $Revision: 1.86.18.2 $ of deliver.pl produces an error like: % deliver deliver -- version: 1.50.8.4.2.1 COPY: ../unxfbsd.pro/bin/makedepend -> /work/ports/editors/openoffice-1.1-devel/work/oo_1.1.2_src/solver/645/unxfbsd.pro/bin/makedepend deliver: /work/ports/editors/openoffice-1.1-devel/work/oo_1.1.2_src/soltools/prj/d.lst: ERROR: Failed to execute /work/ports/editors/openoffice-1.1-devel/work/oo_1.1.2_src/solver/645/unxfbsd.pro/bin/makedepend.95711-1084837695 since there's no definition of $strip for FreeBSD
Created attachment 15319 [details] add $strip for FreeBSD
set several things, target milestone and platform
I will take care of this.
Accepted.
vg: what about using this instead. Think of other unices like NetBSD... --- deliver.pl.~1.50.8.4.2.1.~ 2004-05-18 17:25:51.000000000 +0200 +++ deliver.pl 2004-05-18 17:26:31.153896272 +0200 @@ -131,13 +131,11 @@ $opt_deloutput = 0; # delete the output tree for the project once successfully delivered $gcdynstr = ''; -$strip = ''; +$strip = 'strip'; if ($^O eq 'linux') { $gcdynstr = 'elf-gc-dynstr'; - $strip = 'strip'; }; $strip = '/usr/ccs/bin/strip' if ( $^O eq 'solaris' ); -$strip = 'strip' if ( $^O eq "darwin" ); $upd = $ENV{'UPD'}; ($gui = lc($ENV{GUI})) || die "can't determine GUI";
svesik -> pjanik Looks like an ok solution, please apply
yes. it is preferable. however, if some options to GNU strip and BSD strip is different, how do we do? anyway, your patch is much better than mine. I'm not sure why it has been changed so ad hoc way...
vg: what is the purpose of $gcdynstr? With my patch applied, the code is weird even for me who do not speak Perl ;-)
$gcdynstr is obsolete and should be removed. At one time the Linux linker was not able to remove unused smybol strings from the string table when a map file was employed. We used a tool invented by the mozilla team called elf-gc-dynstr to streamline our binaries. This is history. VG->please remove the $gcdynstr stuff.
Hi, there is a new version with more general concept for stripping, the 1.50.8.7
vq->vg: You must not use: $strip = 'strip' if ($^O ne 'MSWin32'); because $^O only tests the version of the used perl, we support also the perl that comes with cygwin, and it outputs: "cygwin" Also in the not so far future there will be a MinGW port, so that testing only $ENV{"GUI"} is also not correct, I propose testing of $ENV{"GUI"} ne "MSC" .
Sorry, I meant testing $ENV{"COM"} ne "MSC" .
vg->vq: I agree, the your changes are in r1.50.8.8
close issue