Issue 29155 - 1.1.2fix2 build breaks under cygwin-tcsh (guw.pl ?)
Summary: 1.1.2fix2 build breaks under cygwin-tcsh (guw.pl ?)
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: OOo 1.1.2
Hardware: SGI Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 1.1.2
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-13 18:24 UTC by Giuseppe Castagno (aka beppec56)
Modified: 2006-03-14 21:03 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch for config_office and solenv (7.20 KB, patch)
2004-05-15 00:07 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Giuseppe Castagno (aka beppec56) 2004-05-13 18:24:59 UTC
Env.: MS VC++ 6.0+SP5, Win Xp+SP1, cygwin 1.5.9-1.

The build from scratch of cvs tag cws_srx645_ooo112fix2 (i.e. with solver tree
created from scratch) broke in:

=============
Building project sal
=============
<snip>

------------------------------
Making: ../../wntmsci9.pro/obj/fileimpl.obj
guw.pl /cygdrive/c/PROGRA~1/MICROS~2/VC98/bin/cl.exe -Zm200 -c -nologo -Gs -Gy 
-I.  -I. -I../inc -I../../inc -I../../WIN/inc -I../../wntmsci9.pro/inc -I.
-I/cygdrive/l/oo_112fix2-SvrRel/645/wntmsci9.pro/inc/stl
-I/cygdrive/l/oo_112fix2-SvrRel/645/wntmsci9.pro/inc/external
-I/cygdrive/l/oo_112fix2-SvrRel/645/wntmsci9.pro/inc
-I/cygdrive/l/oo_112fix2/OOoSrc/solenv/wntmsci9/inc
-I/cygdrive/l/oo_112fix2/OOoSrc/solenv/inc -I/cygdrive/l/oo_112fix2/OOoSrc/res
-I/cygdrive/l/oo_112fix2/OOoSrc/solver/645/wntmsci9.pro/inc/stl
-I/cygdrive/l/j2sdk1.4.1_07/include/win32 -I/cygdrive/l/j2sdk1.4.1_07/include
-I'/cygdrive/L/ProgramFiles/MicrosoftSDK/include'
-I/cygdrive/c/PROGRA~1/MICROS~2/VC98/include     -I. -I../../res -I. -Ob1 -Ox
-Oy- -Gd      -DWNT -DWNT -DNT351 -DMSC -DMI200 -DINTEL -D_USE_NAMESPACE
-D_X86_=1  -DFULL_DESK -DSTLPORT_VERSION=400 -DWINVER=0x400 -D_WIN32_IE=0x400
-D_MT -DCPPU_ENV=msci -DSUPD=645 -DPRODUCT -DNDEBUG -DPRODUCT_FULL
-DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_OFF -DCUI -DSOLAR_JAVA -DSRX645 
-DMULTITHREAD -DWIN32 -D_MT -D_DLL -DWIN32 -D_MT -D_DLL -W3
-Fo../../wntmsci9.pro/obj/fileimpl.obj
/cygdrive/l/oo_112fix2/OOoSrc/sal/osl/w32/fileimpl.cxx 

guw.pl /cygdrive/c/PROGRA~1/MICROS~2/VC98/bin/cl.exe @/tmp/mkb03896
Command: /cygdrive/c/PROGRA~1/MICROS~2/VC98/bin/cl.exe
fileimpl.cxx

l:\oo_112fix2\OOoSrc\sal\osl\w32\fileimpl.cxx(194) : error C2065:
'INVALID_FILE_ATTRIBUTES' : undeclared identifier

l:\oo_112fix2\OOoSrc\sal\osl\w32\fileimpl.cxx(194) : warning C4018: '!=' :
signed/unsigned mismatch

l:\oo_112fix2\OOoSrc\sal\osl\w32\fileimpl.cxx(288) : error C2065:
'GetVolumeNameForVolumeMountPoint' : undeclared identifier

dmake:  Error code 2, while making '../../wntmsci9.pro/obj/fileimpl.obj'
echo: No match.

ERROR: Error 65280 occurred while making /cygdrive/l/oo_112fix2/OOoSrc/sal/osl/w32
dmake:  Error code 1, while making 'build_all'
echo: No match.

the guw.pl was version 1.11.18.1.

When I changed the guw.pl file back to the 1.11.76.1 version, the build ended
correctly.

So I wasn't stopped, but may be there something to check.
Comment 1 hjs 2004-05-13 18:59:15 UTC
seems to something for you to look into...
Comment 2 quetschke 2004-05-13 19:49:13 UTC
I did test it with .NET2002, but I suspect that VC6 behaves a bit different
when it comes to quotes.

As a guess, can you please try to reproduce the error with guw.pl
version 1.11.18.1 plus the following change:

@@ -145,7 +142,7 @@
 	  $d1 = ".";
 	  print(STDERR "Error: guw.pl: Option:$variable:\nhas a problem! Probably
nonexistent filename with space.\n");
 	}
-	$variable = $d1_prefix.$quotechar.$d1.$quotechar;
+	$variable = $d1_prefix.$d1;
   }
 
   # Sanity check for -X<path>

That means, change the line 148 (or so) to:
	$variable = $d1_prefix.$d1;

If that fixes the problem, I know were the problem comes from. It is already
fixed in the OOo 2.0 tree and I'll backport the fix.
Comment 3 quetschke 2004-05-13 19:52:08 UTC
vq->beppec56: Do you really have a l:/ProgramFiles/MicrosoftSDK/include
directory. I wonder if there ----------------^ is a space missing.
Comment 4 Giuseppe Castagno (aka beppec56) 2004-05-14 08:26:13 UTC
I tryed with the suggested patch to guw.pl (V. 1.11.18.1) and it worked.

beppec56 =-> vq: ProgramFiles is without the space, it's an abit of mine from
the old days when NT had problem with spaces in a non system drive disk, in
order to have some path (but the drive spec.) in different PC, we still have
some NT inst.
Comment 5 quetschke 2004-05-15 00:06:28 UTC
(This is a MSVC6 only problem)

The following patch is a partial backport of issue 27968 that will also fix
this problem.

I'll test a complete build with it and commit it when it succeeds.
Comment 6 quetschke 2004-05-15 00:07:30 UTC
Created attachment 15285 [details]
Patch for config_office and solenv
Comment 7 quetschke 2004-05-15 14:59:29 UTC
Patch to extensions/ is also needed:
<http://www.openoffice.org/nonav/issues/showattachment.cgi/14768/clean_extensions.diff>
Comment 8 quetschke 2004-05-15 21:59:25 UTC
Committed to cws_srx645_ooo112fix2

vq->beppec56. Please check and report back.
Comment 9 Giuseppe Castagno (aka beppec56) 2004-05-16 09:02:53 UTC
beppec56 =-> vq I'll check it out and rebuild, first sal only and if all goes
well I'll retry the whole build.

Giuseppe.
Comment 10 Giuseppe Castagno (aka beppec56) 2004-05-17 13:05:23 UTC
beppec56 =-> vq. The whole build process finished correctly, no errors.
Thank you.
Giuseppe.
Comment 11 quetschke 2004-05-17 13:38:27 UTC
verified
Comment 12 Martin Hollmichel 2004-10-26 00:52:39 UTC
close issue.