Issue 27683 - msfontextract does not build on Windows
Summary: msfontextract does not build on Windows
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1.2
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 1.1.2
Assignee: khendricks
QA Contact: issues@porting
URL:
Keywords:
: 29137 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-04-11 14:59 UTC by pavel
Modified: 2006-04-04 21:00 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-04-11 14:59:49 UTC
Kevin,

Command: /cygdrive/e/MICROS~1.NET/Vc7/bin/cl.exe
cabd.c
e:\home\pavel\BuildDir\ooo_cws_srx645_ooo112fix1_src\msfontextract\wntmsci8.pro\misc\build\libmspack\mspack\system.h(47)
: error C2169: 'memcmp' : intrinsic function, cannot be defined
e:\home\pavel\BuildDir\ooo_cws_srx645_ooo112fix1_src\msfontextract\wntmsci8.pro\misc\build\libmspack\mspack\system.h(56)
: error C2169: 'strlen' : intrinsic function, cannot be defined
cabd.c(607) : warning C4018: '<' : signed/unsigned mismatch
cabd.c(967) : warning C4018: '>' : signed/unsigned mismatch
cabd.c(1150) : warning C4018: '>=' : signed/unsigned mismatch
cabd.c(1167) : warning C4018: '>=' : signed/unsigned mismatch
dmake:  Error code 2, while making '../../../../..//wntmsci8.pro/obj/cabd.obj'
echo: No match.
Comment 1 pavel 2004-04-11 15:02:09 UTC
I ifdef 0'ed both strlen and memcmp and it went further.

P2, because workaround exists.
Comment 2 khendricks 2004-04-11 15:32:12 UTC
Hi,

I am confused.  Volker tested it under WIN and even sent me a number of patches to make it work.
All have been incorporated (insluding the defining of inline to be nothing in system.h

What happens if you simply allow inline to be defined so that these functions will now become inline 
versions of intrinsic functions?  You should always be allowed to define your own version of even 
intrinsic functions under ansi?  Why is this an error?

Is your WIN build environment somehow different from his?

Kevin

Comment 3 pavel 2004-04-11 16:13:21 UTC
Kevin,

I use

checking for cl.exe... /cygdrive/e/Microsoft Visual Studio .NET2002/Vc7/bin/cl.e
xe found.
checking the Version of Microsoft C/C++ Compiler... found Compiler version
001300009466.

I do not know what Volker use (I added him to CC).

Comment 4 khendricks 2004-04-11 16:44:22 UTC
Hi ,

I do not understand why it can't define its own strcmp and memcmp?  Anyone should be able to 
wrapper functions if they want ... perhaps we are including the wrong header in some way?

Volker, if you have any insights into what the problem is, please let me know.  I thought I incorporated 
all of your build fixes.  Did I miss one?

Thanks,

Kevin
Comment 5 pavel 2004-04-11 20:19:08 UTC
Microsoft only says:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/C2169.asp

Compiler Error C2169

'function' : intrinsic function, cannot be defined

A function definition appears for a function already declared intrinsic.

Comment 6 khendricks 2004-04-12 00:05:31 UTC
Hi,

I if 0'd them both out since under Unix "string.h" defines both of them.  Therefore they really are not 
needed for any of our platforms.  Verified this under MacOSX and Linux.

Hopefully this will fix the WIN issue.

Kevin
Comment 7 quetschke 2004-04-12 03:09:36 UTC
Hi!
I also use:
checking the Version of Microsoft C/C++ Compiler... found Compiler version
001300009466.

I lost my buildlog, I start a 112fix1 build with Pavels fix for issue 17295
now, you'll see the result in a while in the tinderbox. 
Comment 8 quetschke 2004-04-12 03:12:06 UTC
I lost the buildlog, but the project was build and the build
continued.
Comment 9 khendricks 2004-04-12 03:18:01 UTC
Hi,

Good to hear.  The removal of strcmp and memcmp must have done the trick.

So it has now been tested on Linux, MacOSX and Win, leaving only FreeBSD and Solaris but my guess is 
they will build as well.

Pavel, I am going to close this as fixed (I hope).  If you run into any other problmes with msfontextract, 
please re-open this one.

Thanks,

Kevin
Comment 10 quetschke 2004-04-12 04:25:55 UTC
Hi Kevin,

yes, but I just realized that I build the new checked-out msfontextract
in a complete build tree. When I build from scratch it fails, because
it uses makedepend without building soltools and I saw earlier
that it links with uwinapi (sal). The latter makes no sense IMHO, but
is true.

I'll update build.lst and try again.
Comment 11 khendricks 2004-04-12 12:52:02 UTC
Hi Volker,

Please commit any needed changes to build.lst (i.e. please add soltools for makedepend and sal since 
the build environment links just about everything with sal).  It iwll not hurt.  This binary is only meant 
to be executed from within the program directory which will have access to libsal.

Thanks,

Kevin
Comment 12 pavel 2004-04-28 16:54:04 UTC
Verified, closing.
Comment 13 quetschke 2004-07-25 03:03:00 UTC
Patch missing in cws_srx645_ooo113fix2.
Comment 14 quetschke 2004-07-25 03:16:32 UTC
Committed again to cws_srx645_ooo113fix2.
Comment 15 quetschke 2004-08-21 17:21:54 UTC
*** Issue 29137 has been marked as a duplicate of this issue. ***
Comment 16 Martin Hollmichel 2006-04-04 21:00:32 UTC
close issue