Apache OpenOffice (AOO) Bugzilla – Issue 26435
W32: compilation of sessionlistener.cxx
Last modified: 2004-04-13 12:30:21 UTC
Hi, MS VC6 is not able to compile sessionmanager.cxx because of missing SAL_CALL in the header. See http://tmp.janik.cz/OpenOffice.org/sessionlistener/snapshot001.png for screenshot of the failed compilation. Patch attached. P2, because of build issue (should be P1, but as the fix is known). My prediction is that *many* people compiling with VC6 will reach this issue in 1.1.1 :-(
Created attachment 13766 [details] Add missing SAL_CALL
set target. I said P2 :-)
TM->MH: Please have a look, thanks !
Hi, I get what I think is the same error with OOo 1.1.1RC3, but with MS VC++ .NET 2002. I even checked the sources out from CVS a second time (tag=SRX645_m35), to be sure I have the correct ones. In this case the error message is: c:\ooo111rc3\framework\source\services\sessionlistener.cxx(164) : error C2259: ' framework::SessionListener' : cannot instantiate abstract class due to following members: 'void com::sun::star::lang::XEventListener::disposing(const com::sun::st ar::lang::EventObject &)' : pure virtual function was not defined The proposed patch appears to fix the problem. BTW, should the summary of this issue not say "sessionlistener.cxx" instead of "sessionmanager.cxx"?
Simon 8) It should.
mh-vg: this file is patched but not been committed in RE master workspace.
There were so many fixes on master in m33, and they hve been commited by developers from my WS. This file has apparently not been commited by othersight.
I know that committed, but not released in an "official" version patches should be RESOLVED FIXED, but I just checked-out OpenOffice_1_1_1 from cvs and tried to build it. (.NET 2002) It fails with: ---------------------------------------------------------------- error C2373: 'framework::SessionListener::disposing' : Neudefinition; unterschiedliche Modifizierer ..\..\inc\services\sessionlistener.hxx(244) : Siehe Deklaration von 'framework::SessionListener::disposing' dmake: Error code 2, while making '../../wntmsci8.pro/slo/sessionlistener.obj' echo: No match. ERROR: Error 65280 occurred while making /cygdrive/d/v1/cws_srx645_ooo111fix3/framework/source/services ---------------------------------------------------------------- Hopefully it is only the cvs tag, and not the to be released source tarball. I'd object against releasing an "unbuildable" source release. Setting target 1.1.1 to reflect this.
Source checked out with CVS tag OpenOffice_1_1_1 is identical to SRX645_m35 right? Or is there a difference?
*** Issue 27197 has been marked as a duplicate of this issue. ***
already fixed in revision 1.1.4.2 of sessionlistener.hxx from 23.03.2004
Thanks for the issuzilla, I'm just trying to build 1.1.1 on W32 and found this bug. I was really frustrated as I did not count on that a final source distro won't compile on a 'standard' platform... A notice on the source donwload page ("known build problems") would be great...
p1 tarball now contains fixed version. verified, closing.
*** Issue 27333 has been marked as a duplicate of this issue. ***