Apache OpenOffice (AOO) Bugzilla – Issue 26133
Wizards: WebWizard fails to open on PPC Plattforms.
Last modified: 2004-09-27 11:21:58 UTC
On the PowerPC Plattforms using Mac OS X or Linux the WebWizards fails to launch. There is only a blank box with an exclamation mark and an OK Button. Kevin B. Hendricks created an patch which works fine with his build and with my build too.
Created attachment 13577 [details] Patch for WebWizard to launch on PPC Plattform
Please have a look.
Hi, I can confirm this issue. The problem seems to be that the HtmlAutoPilotBasic.Main passes a NoArgs() in the arguments to create the private:factory/swriter/web but since NoArgs() was never dimensioned this plays havoc with things generating an error which is cuaght and all you see is an empty error block. This same problem appears with Linux Sparc in the 680 series as well. Once I add the Dim NoArgs() the private:factory/swriter/web URL opens fine and it all works well. This fix is needed for MacOSX and PPC Linux in OOo 1.1.1 and it appears to be needed for Sparc as well. In fact, it should be needed for all platforms. I can't figure out why x86 does not have the same issue. Kevin
Hi, Adding myself to CC on this to keep track of its progress and possible inclusion in OOo 1.1.1 final. Kevin
this patch will not work for Linuxx86
Hi Martin, I am confused. How can it not work? It is simply doing what the other xba files do and that is Dim NoArgs() before using them. What error message are you getting from Dimensioning NoArgs? Here is a greb of share/basic/*/*.xba that show other basic programs doing the same. .//ImportWizard/FilesModul.xba:Dim NoArgs() .//ImportWizard/FilesModul.xba: oLogDocument.StoreAsUrl(sLogUrl, NoArgs()) .//ImportWizard/FilesModul.xba:Dim NoArgs() as New com.sun.star.beans.PropertyVal... So should I instead have done Dim NoArgs() as New blah? What am I missing here? Kevin
mh->tv: can you please answer as you did the test ?
Hi Kevin, I am not quite sure why ther is an Error on Linux PPC. The correct revision of the file <b>wizards/source/webwizard/HtmlAutoPilotBasic.xba</b> is <b>1.31</b>. This revision includes the line <br> <i>Public NoArgs as New com.sun.star.beans.PropertyValue</i> This is also the reason, why another <i>Dim NoArgs</i> leads to an error.<br> Please double-check if you are working with the correct revision of the file...
Hi, Is there any difference between: Public NoArgs()as New com.sun.star.beans.PropertyValue as used in other xba files and Public NoArgs as New com.sun.star.beans.PropertyValue Notice the version you are using has "NoArgs" not "NoArgs()" in the public statement yet passes NoArgs() not NoArgs. To test this I removed my added Dim NoArgs() but then chenged your Public line to use "NoArgs()" and not "NoArg" and everything works agin on both MacOSX and Linux PowerPC. So the Pulbic NoArg is notbeing considered the same thigns as Public NoArgs() for some reason. What happnes on x86 Linux if you change that line from NoArgs to NoArgs()? Thanks, Kevin
I just tested it on X86 Linux both Public NoArgs as New com.sun.star.beans.PropertyValue and Public NoArgs() as New com.sun.star.beans.PropertyValue work, althouth the latter one is more correct because it is defining the Variable as an Array. Since we are passing an empty Array anyways it both works. To achieve code level compatibility, you should use the same version of the file in Linux PPC (that is: the first version).
so the NoArgs() variant works for all platforms now ?
Hi, Both do not work. Passing an array is not the same as passing a non-array under PPC abi. Arrays are passed by reference (i.e. indirected) while non-arrays are not. The "more correct" way is the only way it will work on PPC Linux and MacOSX. I am confused by your "first versus second" reference. The correct cross-platform code should be: Public NoArgs() as New com.sun.star.beans.PropertyValue to match the use of NoArgs() in the method call. So please make change in OOo 1.1.1 final so that it will work for all platforms. Thank you, Kevin
Hi Martin, I can confirm that using the "more correct" NoArgs() works properly on both PPC Linux and MacOSX. tv confirmed it works on Linux x86. I do not have access to a 680 Sparc build to test the same thing for Linux Sparc. Kevin
Kevin! You are absolutely correct. It needs to be NoArgs(). We still do not understand why NoArgs -whithout paranthesis works under X86 (Windows, Linux) So the fix needs to be: RCS file: /cvs/installation/wizards/source/webwizard/HtmlAutoPilotBasic.xba,v retrieving revision 1.31 diff -u -r1.31 HtmlAutoPilotBasic.xba --- HtmlAutoPilotBasic.xba 27 Mar 2003 17:58:56 -0000 1.31 +++ HtmlAutoPilotBasic.xba 10 Mar 2004 14:53:35 -0000 @@ -35,7 +35,7 @@ Public oBaseDocument as Object Public oViewCursor as Object Public oViewSettings as Object -Public NoArgs as New com.sun.star.beans.PropertyValue +Public NoArgs() as New com.sun.star.beans.PropertyValue Public oCursor as Object Public oBookmarks as Object
Hi, Thanks for confirming that. I think the true power of having a product that is built on multiple platforms with multiple abis (x86 Linux, Win and Solaris, PPC on Linux and MacOSX, Sparc on Linux and Solaris) etc is that it helps find lots of little nits that would otherwise stick around longer without testing on multiple platforms. Thanks again for looking at this! Kevin
Fixed on ooo111regression4
Fixed.
close issue.