Issue 25883 - complex eng funcs broken ...
Summary: complex eng funcs broken ...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: OOo 1.1.1b
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-26 07:02 UTC by mmeeks
Modified: 2013-08-07 15:15 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fix complex functions (4.65 KB, patch)
2004-02-26 07:02 UTC, mmeeks 		no flags Details | Diff
test sheet (39.00 KB, application/vnd.ms-excel)
2004-02-26 07:03 UTC, mmeeks 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2004-02-26 07:02:04 UTC 
The attached patch makes the gnumeric engfunc regression tests all pass;

It fixes some pretty obvious / painful bugs:

* =IMREAL("-j") != -1
* preserving the i/j state across operations as-per Excel
* rendering "0+j" as simply 'j' as Excel does.

I attach the gnumeric test spreadsheet (appears to be GPL).

May I commit ? and to which branch ?
Comment 1 mmeeks 2004-02-26 07:02:48 UTC 
Created attachment 13439 [details]
fix complex functions
Comment 2 mmeeks 2004-02-26 07:03:33 UTC 
Created attachment 13440 [details]
test sheet
Comment 3 frank 2004-02-26 11:14:48 UTC 
Hi Eike,

one for you I think.

Frank
Comment 4 ooo 2004-02-26 11:38:47 UTC 
The analysis addin is maintained by Daniel.
Daniel, please take over.

Eike
Comment 5 daniel.rentz 2004-06-03 19:40:19 UTC 
fixed in src680/dr19
Comment 6 daniel.rentz 2004-06-08 16:33:58 UTC 
set to fixed...
Comment 7 daniel.rentz 2004-07-06 16:11:56 UTC 
reopened
Comment 8 daniel.rentz 2004-07-06 16:12:19 UTC 
back to QA
Comment 9 daniel.rentz 2004-07-06 16:12:43 UTC 
fixed
Comment 10 oc 2004-07-12 16:16:13 UTC 
reopened because fixed but failed
Comment 11 oc 2004-07-12 16:17:33 UTC 
Attached xls doc with add-in functions get #NAME as result =>regression
Comment 12 daniel.rentz 2004-07-12 16:21:53 UTC 
DR->JM: Seems to be related to the broken import of defined names (issue 19664)
Comment 13 john.marmion 2004-07-12 20:16:36 UTC 
accepting
Comment 14 john.marmion 2004-07-20 09:46:56 UTC 
checked in latest patch attached to issue 19664 to fix this today to cws/dr19
Comment 15 oc 2004-07-23 16:00:41 UTC 
verified in internal build cws_dr19
Comment 16 daniel.rentz 2005-03-21 17:52:43 UTC 
reopened
Comment 17 daniel.rentz 2005-03-21 17:53:10 UTC 
back to QA
Comment 18 daniel.rentz 2005-03-21 17:53:56 UTC 
fixed
Comment 19 oc 2005-04-06 09:33:44 UTC 
reset verified status
Comment 20 oc 2005-04-06 09:34:36 UTC 
closed because fix available in current master