Issue 25463 - rtl_convertUnicodeToText and sal_Size vs. sal_uInt32
Summary: rtl_convertUnicodeToText and sal_Size vs. sal_uInt32
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: 680m24
Hardware: PC (x86_64) Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: pavel
QA Contact: issues@porting
URL:
Keywords:
: 25575 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-02-13 09:49 UTC by pavel
Modified: 2004-11-29 10:42 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Changing the type of arguments (844 bytes, patch)
2004-02-13 09:51 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-02-13 09:49:05 UTC
This function is declared as

sal_Size SAL_CALL
rtl_convertUnicodeToText( rtl_UnicodeToTextConverter hConverter,
rtl_UnicodeToTextContext hContext,
const sal_Unicode* pSrcBuf,
sal_Size nSrcChars,
sal_Char* pDestBuf,
sal_Size nDestBytes,
sal_uInt32 nFlags,  
sal_uInt32* pInfo,  
sal_Size* pSrcCvtChars
);

The next to last argument is sal_uInt32* pInfo.

There are two calls of this function in
ooo_cws_src680_ooo20040225_src/sal/osl/unx/file.cxx where sal_Size is used instead.

sal_Size is defined as:

inc/sal/types.h:typedef unsigned long       sal_Size;

thus on 64bit systems, sal_Size is 64bit, but sal_uInt32 is only 32bit long.
This patch changes the syntax of those two calls.
Comment 1 pavel 2004-02-13 09:49:51 UTC
Add target, approval_pending keyword.
Comment 2 pavel 2004-02-13 09:50:31 UTC
reassign to me.
Comment 3 pavel 2004-02-13 09:50:58 UTC
accept it.
Comment 4 pavel 2004-02-13 09:51:58 UTC
Created attachment 13098 [details]
Changing the type of arguments
Comment 5 fa 2004-02-14 22:44:32 UTC
Approved for 680 20040225
Comment 6 pavel 2004-02-15 09:42:52 UTC
Thanks, commited.
Comment 7 pavel 2004-02-17 20:52:51 UTC
*** Issue 25575 has been marked as a duplicate of this issue. ***
Comment 8 jens-heiner.rechtien 2004-03-02 17:02:12 UTC
Verified.
Comment 9 pavel 2004-11-29 10:42:34 UTC
.