Apache OpenOffice (AOO) Bugzilla – Issue 2455
Order in which libraries are linked produces unresolved symbols
Last modified: 2010-03-29 21:12:20 UTC
setup2/source/custom/moffice/makefile.mk needs to link mowos.o before SALLIB on IRIX, otherwise will produce unresolved symbols when linking, as IRIX is specific about the order in which files are linked.
Created attachment 769 [details] setup2/source/custom/moffice/makefile.mk - preferable patch
Created attachment 770 [details] setup2/source/custom/moffice/makefile.mk - less preferable patch
the difference b/w the 2 patches is that the second uses a few conditionals to make sure the makefile is uneffected for other platforms. The first has been tested on Linux and made absolutely no difference, and is the preferable choice, as it is much cleaner.
In IRIX, the order in which libraries and objects files are linked is very important. If linked in an incorrect order, the linker can report unresolved symbols. For this reason some makefiles need to changed so that libraries linked in are re-ordered to resolve this problem. AFAIK this will not make any difference to any other unix platforms, (Definately not LINUX, as I have tested the patches to follow on Linux).
Created attachment 772 [details] desktop/source/offwrp/makefile.mk - libraries reordered
This patch has been tested on Linux and worked perfectly fine
Created attachment 773 [details] offmgr/util/makefile.mk - reorder libraries
patch for offmgr/util/makefile.mk has been tested on Linux and has zero impact. Should have no impact on no other platform either.
Created attachment 777 [details] sc/util/makefile.mk - reorder libraries
The patch for sc/util/makefile.mk was tested on Linux and had zero impact. Should not have an impact on any other platforms either
Created attachment 778 [details] sd/util/makefile.mk - reorder libraries
The patch for sd/util/makefile.mk has been tested in Linux and had zero impact. Should not have any impact on any other platforms either.
Created attachment 779 [details] svx/util/makefile.mk - reorder libraries
The patch for svx/util/makefile.mk has been tested with Linux and had zero impact. Should have no impact on no other platform either.
Commited in: setup2/source/custom/moffice/makefile.mk rev 1.7.2.1 desktop/source/offwrp/makefile.mk rev 1.2.8.1 offmgr/util/makefile.mk rev 1.17.2.1 sc/util/makefile.mk rev 1.12.2.1 sd/util/makefile.mk rev 1.14.2.1 svx/util/makefile.mk rev 1.16.2.2 these are all in OOO_STABLE_1
Reopening issue. There is another case in the sw module
Created attachment 5153 [details] patch for sw/util/makefile.mk
mh->georgez: I gave you commit access to the OOO_STABLE_1 branch. please commit by yourself.
Thanks Martin. George
accepting issue
If this cant make it inot 1.0.3, then 1.0.4 is also acceptable. George
retargeting to 1.0.4
tried commiting this, but got: cvs [server aborted]: "commit" requires write access to the repository cvs commit: saving log message in /tmp/cvsBAAa1Z5HT Is the STABLE_1 branch locked?
re-assigning to Nick Blievers
Accepting
Hello, I found that this Issue is targetted to 1.0.4. Can you please retargetting this issue since 1.0.4 is not planned. maybe to 1.1.1 ? and can you remove the keyword, since you already accept it ? Thanks
Changed milestone
No one seems to be actively working on IRIX port thus retargeting to 1.1.2.
No one seems to be actively working on IRIX port thus retargeting to 1.1.3.
No one seems to be actively working on IRIX port thus retargeting to OOoPleaseHelp.
per issue 106845 sb removed the partial irix port, so this doesn't make sense in isolation anymore
closing