Issue 23926 - Accented characters in Mac OSX latest builds
Summary: Accented characters in Mac OSX latest builds
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.2
Assignee: fa
QA Contact: issues@porting
URL:
Keywords: oooqa
: 8734 26182 (view as issue list)
Depends on:
Blocks: 20715
  Show dependency tree
 
Reported: 2003-12-28 19:39 UTC by pchretien
Modified: 2006-04-04 20:54 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd sal, patch -p0 < /path/to/patchfile (36.82 KB, patch)
2004-01-11 21:52 UTC, fa 		no flags Details | Diff
cd solenv, patch -p0 < /path/to/patchfile (780 bytes, patch)
2004-01-11 21:53 UTC, fa 		no flags Details | Diff
cd vcl, patch -p0 < /path/to/patchfile (2.76 KB, patch)
2004-01-11 21:54 UTC, fa 		no flags Details | Diff
cd sal, patch -p0 < /path/to/patchfile enables Hebrew input (37.15 KB, patch)
2004-01-11 22:49 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pchretien 2003-12-28 19:39:00 UTC 
Found what looks to be an issue with special accented caracters (ô â ê and ä ë
ï) useful for German and French users.
Problem appeared in latest builds of OpenOffice.org for Mac OSX.
The above caracters cannot be typed in OpenOffice, neither in texts nor in
worksheets.
Problems looks to be specific to Max OSX builds (does not appear in Windows builds).
Problem is present in builds from 1.1.0 developer preview until latest CVS
(built a fresh one last night).
Mac OSX is 10.3.2 with Apple version of X Windows.
Problem does not seem to come from X Windows itself as caracters are accessible
under X and vi.
Comment 1 terryt 2003-12-29 08:21:45 UTC 
Added oooqa keyword.

Verified behavior with my builds of OOo 1.1.1 (cws_srx645_ooo111fix2) on Mac OS 
X 10.2.x with XFree86 v4.3.0/XDarwin v1.2.0 and window-maker v0.62.x, AND OOo 
1.1rc5 (OpenOffice_1_1).

The problem does NOT occur with OOo 1.0.3GM on the same configuration.

As a workaround, you can use the "Insert Special Character..." menu item.
Comment 2 Martin Hollmichel 2004-01-11 12:45:28 UTC 
reassigned.
Comment 3 fa 2004-01-11 18:59:54 UTC 
ah crap.  I looked at some 111fix1 code and many of the relevant patches are there (the one in 
salframe.cxx dealing with the encoding of keyboard characters and one in i18n_im.cxx dealing 
with input locale) so this one's going to be fun.... :(

Dan
Comment 4 fa 2004-01-11 21:49:10 UTC 
Taking over...   i've got some patches for this.
Comment 5 fa 2004-01-11 21:52:47 UTC 
Created attachment 12423 [details]
cd sal, patch -p0 < /path/to/patchfile
Comment 6 fa 2004-01-11 21:53:42 UTC 
Created attachment 12424 [details]
cd solenv, patch -p0 < /path/to/patchfile
Comment 7 fa 2004-01-11 21:54:32 UTC 
Created attachment 12425 [details]
cd vcl, patch -p0 < /path/to/patchfile
Comment 8 fa 2004-01-11 22:01:01 UTC 
These patches change the Mac OS X locale handling code dramatically.

First, for most western locale's CFStringGetSystemEncoding() would always return Mac Roman 
encoding, for which there is bad support in OOo.  Therefore, we'll use CoreFoundation to grab the 
values that the International control panel gives us for the current process locale, and let OOo do 
the work of text encoding off that.

The patches also revert out some hacks that were valid under the previous system, but no longer 
are with the new system.

Kevin/Ed, can you review these and approve for commit to 111fix2?

dan
Comment 9 fa 2004-01-11 22:49:17 UTC 
Created attachment 12426 [details]
cd sal, patch -p0 <  /path/to/patchfile   enables Hebrew input
Comment 10 khendricks 2004-01-12 01:37:13 UTC 
Hi, 
 
Lot's of changes but all MacOSX specific so approved. 
 
Thanks, 
 
Kevin
Comment 11 fa 2004-01-12 04:56:07 UTC 
committed to ooo111fix2
Comment 12 fa 2004-02-05 20:42:40 UTC 
fixed in 111fix3
Comment 13 terryt 2004-02-24 08:38:07 UTC 
*** Issue 8734 has been marked as a duplicate of this issue. ***
Comment 14 terryt 2004-03-06 08:55:39 UTC 
*** Issue 26182 has been marked as a duplicate of this issue. ***
Comment 15 Martin Hollmichel 2006-04-04 20:54:40 UTC 
close issue