Issue 23922 - 64bit: do not add L modifier after constants
Summary: 64bit: do not add L modifier after constants
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: jens-heiner.rechtien
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 8584
  Show dependency tree
 
Reported: 2003-12-28 14:29 UTC by pavel
Modified: 2004-02-20 11:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Allow compilation on 64bit systems (1.49 KB, patch)
2003-12-28 14:29 UTC, pavel 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-12-28 14:29:28 UTC 
Hi,

the attached patche allow the package project to be compiled on x86_64. On 64bit
systems, we will have different types than the current one.

sal_Int32 could be different than long then.

Please approve for cws_src680_ooo20031216.
Comment 1 pavel 2003-12-28 14:29:58 UTC 
Created attachment 12142 [details]
Allow compilation on 64bit systems
Comment 2 pavel 2003-12-28 14:30:45 UTC 
set target, add approval_pending, dependency
Comment 3 fa 2003-12-30 05:52:05 UTC 
I assume that the L was added to fix compile time warnings?  Perhaps we should simply then cast
the number as:

::std::min( nSize, (sal_Int32)32000 )

or whatever type ::std::min() requires.
Comment 4 jogi 2004-01-08 08:43:11 UTC 
JSI->reporter: Thank you for your support of OOo. All build issues should be
better submitted to the 'porting' project. Thank you!
Comment 5 jens-heiner.rechtien 2004-01-08 10:19:40 UTC 
Approved for cws_src680_ooo20031216. Please go ahead.
Comment 6 pavel 2004-01-08 17:16:34 UTC 
Fixed in cws_src680_ooo20031216.
Comment 7 pavel 2004-01-09 20:11:23 UTC 
Hmm, the same as in 23939 applies - I fixed the compilation by using static_cast.
Comment 8 Martin Hollmichel 2004-02-20 11:07:40 UTC 
close issue.