Issue 23345 - configure breaks with .NET2002 in some cases
Summary: configure breaks with .NET2002 in some cases
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: OOo 1.1
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 22955
  Show dependency tree
 
Reported: 2003-12-09 14:27 UTC by quetschke
Modified: 2006-03-14 21:02 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch for configure.in (1.02 KB, patch)
2003-12-10 00:45 UTC, quetschke
no flags Details | Diff
Patch for configure.in (1.92 KB, patch)
2003-12-11 03:02 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-12-09 14:27:06 UTC
This is for branch cws_srx645_ooo111fix1

Configure breaks with .NET2002 if cl.exe is used before --with-mspdb-path is
evaluated.

This is the case for:

dnl The following checks for gcc, cc and then (cl if win32)
AC_PROG_CC

and

AC_HEADER_STDC

Easy solution, but a if OS != WNT guard around them and everything is fine,
or move the
dnl ===================================================================
dnl  Check which Microsoft C/C++ or MinGW compiler is used for WINNT
dnl ===================================================================
part before these commands.

I'll produce a patch this evening.

Setting prio to 1 because build is broken for .NET2002.
Comment 1 quetschke 2003-12-09 14:31:18 UTC
Setting target to 1.1.1

Re-setting prio to P2 because if you include the path to mspdb?.dll in your PATH
before calling calling configure it still builds.
Comment 2 quetschke 2003-12-10 00:45:12 UTC
Created attachment 11844 [details]
Patch for configure.in
Comment 3 quetschke 2003-12-10 00:47:21 UTC
This patch should do, if approved is there a branch to committ it to?
Comment 4 pavel 2003-12-10 08:10:13 UTC
with bash/cygwin:

./configure '--with-jdk-home=C:\jdk1.4.1_05' --with-dict=ALL --with-lang=ENUS,
CZECH,SLOVAK,DAN,HUNG,SLOVENIAN,DTCH,FINN --with-asm-home=/cygdrive/c/OOo/ml --w
ith-use-shell=tcsh --disable-crashdump

checking the operating system... checked (WINNT)
checking for gcc... gcc
checking for C compiler default output file name... a.exe
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... .exe
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ANSI C... none needed
checking for gcc... /usr/bin/gcc
checking the GNU gcc compiler version... configure: error: found version "2.95.3
-5", use version 3+ of the gcc compiler
Comment 5 quetschke 2003-12-10 14:01:51 UTC
Ahh, I see, but that is Kens "Baustelle" ;-)

* Can you confirm that it works when you use --with-cl-home ?

* Why don't you update your gcc package in cygwin? ;-)

* I'll put a guard around Kens check for MS, non-mingw builds this evening.

Volker
Comment 6 pavel 2003-12-10 18:00:21 UTC
Hi,

after

./configure '--with-jdk-home=C:\jdk1.4.1_05' --with-dict=ALL
--with-lang=ENUS,CZECH,SLOVAK,DAN,HUNG,SLOVENIAN,DTCH,FINN
--with-asm-home=/cygdrive/c/OOo/ml --with-use-shell=tcsh --disable-crashdump
--with-cl-home=/cygdrive/c/Progra~1/Micros~3/VC98

the last line printed from configure is:

checking for gcc... /cygdrive/c/Progra~1/Micros~3/VC98/bin/cl

and this is everything. It didn't finished thus there is probably some issue
with it too as I pointed out at
http://www.openoffice.org/issues/show_bug.cgi?id=22955

BTW: this system is about 200km away from me and I do not use GCC for anything
there but people working on that system use it so it is their responsibility to
upgrade should they need it. I do not want to intervent in their work.
Comment 7 quetschke 2003-12-10 22:22:37 UTC
Hi Pavel,

> the last line printed from configure is:
>
> checking for gcc... /cygdrive/c/Progra~1/Micros~3/VC98/bin/cl
>
> and this is everything. It didn't finished thus there is probably some issue
> with it too as I pointed out at
> http://www.openoffice.org/issues/show_bug.cgi?id=22955

I guess I know what's wrong, but I'm at work right now and I cannot
do anything until I'm back.

> BTW: this system is about 200km away from me and I do not use GCC for
> anything there but people working on that system use it so it is their
> responsibility to upgrade should they need it. I do not want to intervent
> in their work.

Ok, ok, next time I put a smilie behind such a sentence, basically it's just
a bug, configure has to work for any gcc compiler when we use MS compilers.

Volker
Comment 8 quetschke 2003-12-10 22:27:37 UTC
Hmm, there was a smilie ;-)
Comment 9 quetschke 2003-12-11 03:02:45 UTC
Created attachment 11884 [details]
Patch for configure.in
Comment 10 quetschke 2003-12-11 03:04:34 UTC
New patch, this should also solve issue 22955. Don't forget to run autoconf
to get configure regenerated.
Comment 11 quetschke 2003-12-11 15:30:53 UTC
vq->hr: As you're doing the fix1 integration, this should also
go in. I tested the last version of the patch with a MSVC6-4nt
configuration.
Comment 12 pavel 2003-12-11 19:08:53 UTC
vq: I have seen the smiley too ;-) Unfortunately I'm not able to test the patch
right now. Xmas will kill me soon...
Comment 13 quetschke 2003-12-11 21:32:00 UTC
I did check for Windows.

vq->waratah: Ken can you test with *nix?
Comment 14 foskey 2003-12-12 21:42:34 UTC
Approved no problem.

ON thing to check is that the test for GCC=YES does not need the extra clutter,
I think if you avoid the compiler checking then GCC will != YES
Comment 15 quetschke 2003-12-12 22:15:36 UTC
vq->waratah: I guess you're right, AC_PROG_CC sets the GCC variable. I'll change
the "clutter" into a comment once I commit it into ...fix2. 
Comment 16 Martin Hollmichel 2003-12-19 06:51:39 UTC
reassigned to vq as he takes action on it, please mark as fixed once committed
to fix2
Comment 17 pavel 2003-12-20 09:59:57 UTC
This makes the build not possible with fix2:

./configure '--with-jdk-home=C:\jdk1.4.1_05' --with-dict=ALL
--with-lang=ENUS,CZECH,SLOVAK,DAN,HUNG,SLOVENIAN,DTCH,FINN
--with-asm-home=/cygdrive/c/OOo/ml --with-use-shell=tcsh --disable-crashdump
--with-cl-home=/cygdrive/c/Progra~1/Micros~3/VC98

is stucked at

checking for gcc... /cygdrive/c/Progra~1/Micros~3/VC98/bin/cl

and does not continue...

raising prio to P1.
Comment 18 quetschke 2003-12-20 16:41:55 UTC
> is stucked at
> 
> checking for gcc... /cygdrive/c/Progra~1/Micros~3/VC98/bin/cl

This output belongs
   AC_PROG_CC ,
but this is now guarded with

if test "$_os" != "WINNT" -o "$WITH_MINGWIN" = "yes"; then
   AC_PROG_CC
fi

so if you don't have WITH_MINGWIN set this test isn't executed for WINNT.
I guess you didn't regenerate your configure.

I just committed configure.in and configure to cws_fix645_ooo111fix2.

Resolving fixed. 

You used:

> ./configure '--with-jdk-home=C:\jdk1.4.1_05' --with-dict=ALL
-------------------------------^^^
Does that really work?
> --with-lang=ENUS,CZECH,SLOVAK,DAN,HUNG,SLOVENIAN,DTCH,FINN
> --with-asm-home=/cygdrive/c/OOo/ml --with-use-shell=tcsh --disable-crashdump
> --with-cl-home=/cygdrive/c/Progra~1/Micros~3/VC98
Comment 19 pavel 2003-12-20 22:26:17 UTC
verified - thanks.

BTW - --with-jdk-home=C:\jdk1.4.1_05 is a remnant from migration. Of course it
does not work ;-)
Comment 20 utomo99 2004-01-15 06:31:35 UTC
I try to update the config_office directory by tortoise cvs today. 
I try again without this patch, but I got error. 
when I applied this patch everything is OK. 
so maybe this patch is not yet included in fix2 ? 
or I wrongly update ? 
Thanks

 
Comment 21 quetschke 2004-01-15 14:12:03 UTC
Hi utomo, I never used tortoise cvs, but make sure that you really
use the branch cws_fix645_ooo111fix2 .

I just checked, the changes are in that branch.