Issue 22989 - Using -eq and comparing strings in configure
Summary: Using -eq and comparing strings in configure
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1
Hardware: PC FreeBSD
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: foskey
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-28 20:23 UTC by pavel
Modified: 2003-11-29 07:59 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-11-28 20:23:37 UTC
Hi Ken,

configure on FreeBSD with gcc 3.2.3 gives me:

checking whether we are using the GNU C compiler... yes
checking whether /home/pavel/BuildDir/ccache /usr/local/gcc-3.2.3/bin/gcc
accepts -g... yes
checking for /home/pavel/BuildDir/ccache /usr/local/gcc-3.2.3/bin/gcc option to
accept ANSI C... none needed
checking the GNU gcc compiler version... ./configure: line 3080: test: : integer
expression expected
checked (gcc 3.2.3)

The problem is that there is a code like this:

                 if test "$ENABLE_SYMBOLS" -eq "SMALL"; then

Is it okay with you to commit this to both configure and configure.in?

-                 if test "$ENABLE_SYMBOLS" -eq "SMALL"; then
+                 if test "$ENABLE_SYMBOLS" = "SMALL"; then
Comment 1 pavel 2003-11-28 20:24:16 UTC
Add approval_pending keyword.
Comment 2 foskey 2003-11-29 01:07:27 UTC
Appoved and comitted.

Thanks for picking this up.
Comment 3 pavel 2003-11-29 07:57:52 UTC
Verified.
Comment 4 pavel 2003-11-29 07:59:30 UTC
-