Issue 22440 - setup segfaults from SiBasic::Error() when -nogui passed in
Summary: setup segfaults from SiBasic::Error() when -nogui passed in
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC5
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: Olaf Felka
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-13 20:45 UTC by fa
Modified: 2004-03-18 15:11 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd setup2, patch -p1 < /path/to/patchfile (560 bytes, patch)
2003-11-13 20:46 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-11-13 20:45:11 UTC 
SiBasic::Error() does not check m_rEnv.HasVCL() (which returns false if -nogui
is passed into setup from the command line) before running off to call InfoBox,
which uses the VCL.  Well, since -nogui was passed the VCL is not inited, and
this causes setup to segfault in SalFrameData::Init().

Attached patch checks m_rEnv.HasVCL() and if TRUE, calls InfoBox, but if FALSE,
prints the error out to stderr.
Comment 1 fa 2003-11-13 20:46:06 UTC 
Created attachment 11243 [details]
cd setup2, patch -p1 < /path/to/patchfile
Comment 2 fa 2003-11-13 21:13:34 UTC 
committed to cws_srx645_ooo111fix1, approved by Nesshof on IRC
Comment 3 Olaf Felka 2003-11-14 08:51:34 UTC 
Hi Dirk,
is this something you should give some attention?
Comment 4 Martin Hollmichel 2003-11-18 12:33:00 UTC 
setting to fixed, as already committed to ooo111fix1
Comment 5 dirk.voelzke 2004-02-05 09:18:23 UTC 
Please verify.
Comment 6 fa 2004-02-08 02:31:07 UTC 
Verified.  Problem fixed.
Comment 7 Olaf Felka 2004-03-18 15:11:13 UTC 
Fixed.