Issue 22042 - Spell checker fails to properly check documents written in UPPER CASE
Summary: Spell checker fails to properly check documents written in UPPER CASE
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: Website general issues (show other issues)
Version: current
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: ---
Assignee: issues@lingucomponent
QA Contact: issues@lingucomponent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-03 08:30 UTC by Unknown
Modified: 2013-02-24 20:34 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
the bugdoc the reporter send to me (9.30 KB, application/octet-stream)
2003-11-13 09:55 UTC, jack.warchold
no flags Details
simple fix to have allcaps check if proper noun version exists (1.25 KB, patch)
2003-11-13 14:58 UTC, khendricks
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-11-03 08:30:02 UTC
When using the Spell checker on documents written entirely in UPPER CASE, spell 
checker misses obvious mistakes (eg NOTM). The option to check UPPER CASE is 
turned on and spell checker picks up some mistakes but misses others.
Comment 1 jack.warchold 2003-11-06 15:27:22 UTC
please attach a document. would be more easier to reproduce this with 
an document the error occurs on, ok i know it would be easy to create 
one, but in this time i can't look for other issues. by testing it on 
a document that allready exist, and the error occurs on i can be shure 
to find the exact type of the error.

reassigned to jw
Comment 2 thomas.lange 2003-11-07 05:56:47 UTC
TL: Works fine is SO with NOTM.
Thus I suspect the word id part of OOo's affix dictionaries.

TL->Kevin: Can you please have a look?
Comment 3 khendricks 2003-11-07 13:04:29 UTC
Hi, 
 
I tested this using the following sentence: 
 
I AM USING A SENTENCE WITH NOTM IN IT. 
 
I then went to Tools->Options->LanguageSettings->WritingAids and enabled check 
uppercase. 
 
The results was that NOTM was detected properly as being incorrect and the 
following words were suggested: 
 
NOT 
NORM 
NOTE 
NOT M 
 
So with the latest version of OOo, I can not recreate this problem at all. 
 
Perhaps some of the words are written in a graphic symbol font that is purposefully 
ignored by spellchecking or are not in the en_US language? 
 
Either way, the spellchecker happily spell checkes NOTM correctly and other 
incorrectly spelled uppercase only words with the right options selected. 
 
So I can not recreate this. 
 
So I am closing this as works for me. 
 
Please re-open once you have attached a document to this issue that actually 
shows the problem and that does not use a graphical symbol font and does not use 
another language setting from en_US. 
 
Thanks, 
 
Kevin 
 
 
 
Comment 4 jack.warchold 2003-11-13 09:55:20 UTC
Created attachment 11225 [details]
the bugdoc the reporter send to me
Comment 5 jack.warchold 2003-11-13 09:57:14 UTC
the reporter just told me that he is using english uk or english nz 
settings in his document and that he thinks that this is the problem.
Comment 6 khendricks 2003-11-13 14:32:11 UTC
Hi,

This document does show one bug that still needs to be fixed even under en_US.

It seems that the en_US dictionary has the root entry "October"  since it is a proper 
noun, and it does NOT have the entry "october" for that same reason.  

The problem is that MySpell checks the uppercase only word and if not in the list, it 
then tries it all demoted to lowercase to check if if are correct.

For example "NASA" exists in the dictionary in exactly that form (all uppercase) so it is 
found and correct.  "LITTLE" does not exist in all uppercase and so is demoted to 
"little" and checked and found to be correct.  But "OCTOBER" does not exist in exactly 
that form and so is demoted to october (OCTOBER -> october) but that is not found 
since the all lowercase form is incorrect for a proper noun. 

So I need to add another pass that for all uppercase words that do not exist in all 
uppercase form, I should try both as all lowercase and as intial capital before claiming 
the word is incorrect.

I will try to get this fix in to the next 1.1.2 build if possible.

So I am re-opening this to track this particular bug.

Kevin
Comment 7 khendricks 2003-11-13 14:33:59 UTC
Hi,

Changing this to be owned by lingucomponent and confirming issue.

Kevin
Comment 8 khendricks 2003-11-13 14:57:13 UTC
Hi,

I now have a patch that fixes this.

It changes the order since all lower is most likely, proper noun next most likely, all 
caps least likely.

I have tested this patch and its does the trick.

Thomas can you approve this patch for OOo 1.1.1 fix1 since it is simplyt and does fix 
a problem.

Thanks,

Kevin

Patch is attached.
Comment 9 khendricks 2003-11-13 14:58:15 UTC
Created attachment 11239 [details]
simple fix to have allcaps check if proper noun version exists
Comment 10 khendricks 2003-11-13 14:58:54 UTC
Setting the target mielstone to 1.1.1 since it is a safe patch and obvious fix.


Kevin
Comment 11 thomas.lange 2003-11-13 15:15:33 UTC
The patch is OK for me.
Comment 12 khendricks 2003-11-14 15:13:15 UTC
Hi, 
 
Patch committed to cws_srx645_ooo111fix1 today. 
 
I am closing this as fixed. 
 
Please verify once OOo 1.1.1 has been released. 
 
Kevin 
 
Comment 13 Martin Hollmichel 2004-10-15 15:16:21 UTC
close issue.