Issue 21201 - bash/cygwin build and sdk_oo
Summary: bash/cygwin build and sdk_oo
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: quetschke
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-15 07:13 UTC by pavel
Modified: 2004-02-27 13:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for sdk_oo/pack/copying/makefile.mk (668 bytes, patch)
2003-10-15 07:31 UTC, quetschke 		no flags Details | Diff
Patch for sdk_oo/util/makefile.pmk (813 bytes, patch)
2003-10-17 23:15 UTC, quetschke 		no flags Details | Diff
Patch for makefile.pmk without touching dircmp (685 bytes, patch)
2003-10-19 19:22 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-10-15 07:13:32 UTC 
Hi,

xcacek@DROGO:~/p/BuildDir/ooo_1.1.0_src/sdk_oo> build --from sdk_oo
...
echo DKNAME=OpenOffice.org1.1_SDK>>
../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk
echo BUILDID= 645m19(Build:8693)>>
../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk
Badly placed ()'s.
dmake:  Error code 1, while making
'../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk'
dmake:  '../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk' removed.
echo: No match.
/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/sdk_oo/pack/check
/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/sdk_oo/util

ERROR: error 65280 occurred while making
/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/sdk_oo/pack/copying
xcacek@DROGO:~/p/BuildDir/ooo_1.1.0_src/sdk_oo> 

The line

echo BUILDID= 645m19(Build:8693)>>
../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk

should read

echo 'BUILDID= 645m19(Build:8693)'>>
../../wntmsci9.pro/bin/OpenOffice.org1.1_SDK/settings/dk.mk

when in bash. This code comes from pack/copying/makefile.mk:

.IF "$(GUI)"=="UNX"
        echo 'BUILDID= $(RSCREVISION)'>> $@
        echo 'DKREGISTRYNAME=$$(subst \\,\,"$$(OFFICE_PROGRAM_PATH)$$(PS)types.r
db")' >> $@
.ELSE
        echo BUILDID= $(RSCREVISION)>> $@
        echo DKREGISTRYNAME=$$(subst \\,\,"$$(OFFICE_PROGRAM_PATH)$$(PS)types.rd
b") >> $@
.ENDIF
Comment 1 quetschke 2003-10-15 07:31:28 UTC 
Created attachment 10322 [details]
Patch for sdk_oo/pack/copying/makefile.mk
Comment 2 quetschke 2003-10-15 07:34:18 UTC 
Hi Pavel, if you approve this patch, please commit.

Don't close the issue, I saw some "del" instead of "rm" during my
testrun, I'll hunt them down later.
Comment 3 pavel 2003-10-15 07:41:12 UTC 
OK, del is in sdk_oo

util/makefile.pmk:MY_DELETE_RECURSIVE=del /sxyf
Comment 4 pavel 2003-10-15 07:53:38 UTC 
echo arguments quoting fixed in fix1.
Comment 5 quetschke 2003-10-17 23:15:21 UTC 
Created attachment 10423 [details]
Patch for sdk_oo/util/makefile.pmk
Comment 6 quetschke 2003-10-17 23:19:13 UTC 
The previous patch depends on the approval from issue 21385
because it also removes the unused MY_DIRCMP macro.
Comment 7 quetschke 2003-10-19 19:22:44 UTC 
Created attachment 10456 [details]
Patch for makefile.pmk without touching dircmp
Comment 8 quetschke 2003-10-19 19:26:01 UTC 
Committed the last sdk_oo.diff patch to cws_srx645_ooo111fix1, without
touching the dircmp problem.
Comment 9 Martin Hollmichel 2004-02-27 13:08:26 UTC 
close issue