Issue 20801 - Patch for truncated string in Hungarian (Dialog tab page " word completion")
Summary: Patch for truncated string in Hungarian (Dialog tab page " word completion")
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: OOo 1.1
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-06 22:22 UTC by timar74
Modified: 2013-08-07 15:00 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proof of the concept - before the patch (31.42 KB, image/png)
2003-10-06 22:28 UTC, timar74 		no flags Details
Proof of the concept - after the patch (31.99 KB, image/png)
2003-10-06 22:32 UTC, timar74 		no flags Details
Wrong word completion dialog panel in 1.9.93 under WXP (24.79 KB, image/png)
2005-04-16 15:26 UTC, kami911 		no flags Details
Patch for 2.0 based on M92 source (793 bytes, patch)
2005-04-17 15:11 UTC, kami911 		no flags Details | Diff
Patch for 2.0 based on M92 source (793 bytes, patch)
2005-04-17 15:12 UTC, kami911 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description timar74 2003-10-06 22:22:56 UTC 
We usually make the translation shorter if it does not fit to its place
in the dialog box, but in this case it was not possible. There is plenty
of space on this particular dialog, so I created (and tested) a trivial
patch. I don't think it can break anything.

--- oo_1.1_src/offmgr/source/offapp/dialog/autocdlg.src.orig    Thu Jul 17
15:47:05 2003
+++ oo_1.1_src/offmgr/source/offapp/dialog/autocdlg.src Thu Oct  2 16:07:58 2003
@@ -2673,7 +2673,7 @@
     CheckBox CB_KEEP_LIST
        {
         Pos = MAP_APPFONT( 10, 59 );
-        Size = MAP_APPFONT( 110, 30 );
+        Size = MAP_APPFONT( 110, 40 );
         WordBreak = TRUE;
         Text = "~Beim Schließen eines Dokuments Liste für spätere Verwendung
speichern";
         Text[ english_us ] = "~When closing a document, save the list for later
use in other documents.";
Comment 1 timar74 2003-10-06 22:28:27 UTC 
Created attachment 10053 [details]
Proof of the concept - before the patch
Comment 2 timar74 2003-10-06 22:32:33 UTC 
Created attachment 10054 [details]
Proof of the concept - after the patch
Comment 3 pavel 2003-10-06 22:36:24 UTC 
Confirmed.
Comment 4 Dieter.Loeschky 2003-10-10 15:18:02 UTC 
DL->SBA: Would you please takeover?
Comment 5 stefan.baltzer 2003-10-15 13:30:32 UTC 
SBA->OS: As discussed, yours. 
I'm changing the issue type from "Defect to "Patch". Changed summary
to meet the facts. Reassigned to Oliver.
Comment 6 Oliver Specht 2003-10-15 13:54:23 UTC 
.
Comment 7 Oliver Specht 2003-12-04 15:37:53 UTC 
Fixed in cws dialogdiet - now in svx/source/dialog/autocdlg.src
Comment 8 Oliver Specht 2005-03-31 11:06:04 UTC 
Closing
Comment 9 kami911 2005-04-16 15:23:58 UTC 
This dialog box problem still remain problem in 1.9.93. I will reopen it and
please resize the checkbox's text.
Comment 10 kami911 2005-04-16 15:26:39 UTC 
Created attachment 25126 [details]
Wrong word completion dialog panel in 1.9.93 under WXP
Comment 11 kami911 2005-04-17 15:11:09 UTC 
Created attachment 25139 [details]
Patch for 2.0 based on M92 source
Comment 12 kami911 2005-04-17 15:12:33 UTC 
Created attachment 25140 [details]
Patch for 2.0 based on M92 source
Comment 13 kami911 2005-04-23 19:38:38 UTC 
It is only cosmetic bug, but pjanik can force it :o)
Thanks
Comment 14 kami911 2005-05-01 09:41:35 UTC 
pjanik: Can you integrate into your build system, then integrate one of your CWS?

Thanks,
KAMI
Comment 15 pavel 2005-05-01 11:07:13 UTC 
This is UI dependent -> the decision is on Sun people.
Comment 16 kami911 2005-05-01 11:34:40 UTC 
SBA: Can you check it again?
Comment 17 pavel 2005-05-19 05:41:51 UTC 
comment needed in this issue or change the target to 2.0.1, please.
Comment 18 kami911 2005-05-19 06:11:57 UTC 
It is a small patch (only one line) the solutioun is already available weeks
ago, so why should we waiting for the next bugfixing release?
Comment 19 pavel 2005-05-19 10:53:11 UTC 
kami_ even one line can affect Czech UI, German UI, English UI, Russian UI,
Slovak UI, ...
Comment 20 timar74 2005-05-19 11:19:53 UTC 
pjanik: Yes, in general one line can affect all languages and a fix for one
language can make things worse for other languages. However, in this very case,
if someone takes a look at the screenshots and the patch itself, it becomes
clear that there is enough room on the dialog for this change.

I understand if paid developers at Sun are reluctant to make this change,
because they are bound to rules and have to go through formal procedures even
for this small change. They have better things to do. But the reasoning that
this patch can have unwanted side effects is not appropriate, IMHO.
Comment 21 pavel 2005-05-19 16:14:09 UTC 
> However, in this very case, if someone takes a look at the screenshots and
> patch itself, ...

Timar, this is the reason I asked os for comment.
Comment 22 Oliver Specht 2005-07-12 11:20:13 UTC 
Fixed in cws tl13 in svx/source/dialog/autocdlg.src
Comment 23 Oliver Specht 2005-07-14 15:32:54 UTC 
Reassigned for verification

Can also be verified in a English version. The FixedText now uses the available
space completely. Can be seen using the debug-option for dialogs

re-open issue and reassign to mru@openoffice.org
Comment 24 Oliver Specht 2005-07-14 15:32:59 UTC 
reassign to mru@openoffice.org
Comment 25 Oliver Specht 2005-07-14 15:33:05 UTC 
reset resolution to FIXED
Comment 26 michael.ruess 2005-07-15 10:06:44 UTC 
Verified fix in CWS tl13.
Comment 27 michael.ruess 2005-08-17 11:24:34 UTC 
Closed, Checked fix in 680m121.