Apache OpenOffice (AOO) Bugzilla – Issue 20264
rtf writing enhancement
Last modified: 2013-08-07 14:41:36 UTC
This patch enables 1. Writing font face name with local charset 2. Writing standard (MS Word builtin) style names in its canonical (English) name 3. Writing text with local charset Thus makes output RTF compatible with older non-unicode applications such as MS Word 95
Created attachment 9748 [details] The patch itself
can you please take a look at this? i think this is sth. for you reassigned to cmc
utomo > cmc. please check the patch. hope we can use it in 1.1.1
Hi, cmc, is it possible to review this patch? or setting correct target milestone? 1.1.1 is preferred.
I have some similiar work done for 2.0 recently, though this adds more. I have to check this against what I've done. There are some interesting wrinkles with fontnames of fonts that have a native "unicode" charset for example, see issue 10538. This is also related to issue 19112. I'll look at this on monday (13th Oct) I prefer 2.0 for this.
cmc->mmaher: Me bad, I never commited this patch to our workspaces. It now needs some tweaking as the code it affects has been somewhat changed.
MM->Tono: Can you update this patch. Code base for this stuff has changed quite a bit. Sorry for the delay, I will reapply this patch as soon as I get a review done. Thx!
Tono->MM: Roger. Will you please specify the CVS tag of the codebase I should work with?
MM->Tono: If you could use the latest 2.0 codebase (SRC680) that would be best.
Martin, you might want to provide a concrete tag name to ease the recreation of the patch. Thanks, Stefan
Created attachment 16140 [details] Patch for SRC680_m43
I have modified my patch for SRC680_m43. Takashi Ono
Hi Martin, the patch has been updated...
mmaher->tono: Thx tono for the update patch I have applied it to my latest workspace. Can you please attach a test document that proves this patch works so that QA can verify the patch before integration.
Reopened to attach test data files.
Oopps, I still cannot attach test data after reopenning the iisue. What should I do?
mmaher->tono: I don't think you have to reopen a bug to attach a document. Just clicko on the "create a new attachment link" below keywords. If you are still having problems you could always email the doc to me and I will attach it. Thx...
Created attachment 17021 [details] Japanese SO document
Created attachment 17023 [details] word 7 generated rtf
Created attachment 17024 [details] word 8 generated rtf
mmaher: attached test documents (thanks tono)
reopen to reassign
reassigning to mru
Fixed in adare
Verified fix in adarefilterteam29.
Checked integration in 680m60.
Japanese development team found out that this fix has a bug. On systems with EUC-jp as a default encoding for Japanese language like linux, generated RTF is encoded in EUC-jp while RTF standard encoding for Japanese ( charset #128 ) is MS-shiftjis. We have to encode RTF with Microsoft standard encoding and I will post an additional patch.
Created attachment 22009 [details] Additional patch for fix encoding problem
Please do not open such issues, if ther's ONE problem with ONE certain encoding. The issue itself is fixed. so please file a new issue with the required information. That is a VERY MUCH better issue handling! Thanks for your patience.
Closed.