Issue 20215 - Invalid C code in setup2/mow/source/loader/loader.c
Summary: Invalid C code in setup2/mow/source/loader/loader.c
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: current
Hardware: Sun Solaris
: P2 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: sander_traveling
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-26 21:13 UTC by pavel
Modified: 2003-12-11 15:22 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Fix invalid C code (438 bytes, patch)
2003-09-26 21:15 UTC, pavel 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-09-26 21:13:57 UTC 
Sander,

the file setup2/mow/source/loader/loader.c is compiled with C compiler,
but contains invalid C code!

        if( pLDPath )
        {
            pLDPath = strdup( pLDPath );

            char* pToken = strtok( pLDPath, ":" );
            while( pToken != NULL )

The line starting with char * was probably added by someone who prefers
C with with some operators added ;-) Please fix this too before release.

Proposed patch attached.
Comment 1 pavel 2003-09-26 21:15:01 UTC 
Created attachment 9705 [details]
Fix invalid C code
Comment 2 Martin Hollmichel 2003-09-29 08:43:21 UTC 
mh->svesik: just another new source tar ball :(.
Comment 3 sander_traveling 2003-09-29 15:57:24 UTC 
no, the change should be present in the rc5b tarball - it was the
reason the upload didn't happen on friday evening.
Comment 4 pavel 2003-09-29 19:42:57 UTC 
Thanks.
Comment 5 jens-heiner.rechtien 2003-12-11 15:22:40 UTC 
.