Issue 20189 - Define BUILD_SPECIAL should not get set for everyone
Summary: Define BUILD_SPECIAL should not get set for everyone
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC5
Hardware: Sun SunOS
: P2 Trivial (vote)
Target Milestone: OOo 1.1
Assignee: sander_traveling
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-26 14:32 UTC by rt
Modified: 2003-09-30 10:22 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description rt 2003-09-26 14:32:08 UTC 
On branch mws_srx645 offmgr/source/offapp/intro/makefile.mk, line 76 ff, reads 
.IF "$(BUILD_SPECIAL)"==""
RSCUPDVERMAC+=-DOOO_VENDOR="$(USER)$(USERNAME)" -DOOO_LICENSE="LGPL"
-DBUILD_SPECIAL=True
.ELSE
RSCUPDVERMAC+=-DBUILD_SPECIAL=True
.ENDIF

That's obviously wrong. In case no environment variable BUILD_SPECIAL is set,
there must not be a compiler define -DBUILD_SPECIAL.
Please fix line 77 of makefile.mk and redo source tar balls for OOo 1.1 rc5 to
include this fix.
Comment 1 rt 2003-09-26 14:37:16 UTC 
Target set to OOo 1.1
Comment 2 sander_traveling 2003-09-26 18:05:13 UTC 
accepting
Comment 3 sander_traveling 2003-09-26 18:10:12 UTC 
fix checked in and tagged as OpenOffice_1_1 - I'll respin solvers and 
make new source tarballs when anoncvs has updated
Comment 4 stx123 2003-09-29 16:14:56 UTC 
Seems this has been fixed by OOo_1.1rc5b tarballs.
Could somebody verify and close.
Comment 5 pavel 2003-09-30 10:22:28 UTC 
Verified.
Comment 6 pavel 2003-09-30 10:22:46 UTC 
Closing.