Issue 20181 - Provide temporary fix for comma / dot on Keypad
Summary: Provide temporary fix for comma / dot on Keypad
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: ui (show other issues)
Version: OOo 1.0.0
Hardware: PC Windows 2000
: P3 Trivial with 4 votes (vote)
Target Milestone: ---
Assignee: Martin Hollmichel
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-26 12:39 UTC by andreschnabel
Modified: 2013-08-07 15:13 UTC (History)
16 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description andreschnabel 2003-09-26 12:39:29 UTC
please See issue 1820 for details. 
The Enhancement for 2.0 should be provided in Issue 1820. I open this separate
issue as requested by Joerg Barfurth.

Relevant details from Issue 1820:

--------------------
http://www.via.ecp.fr/%7Eremi/win/ooovirg/ooovirg.php3
Maybe worth a look, if this could be the solution. If yes, someone
should contact the Author if he is willng to contribute directly to 
OOo.
--------------------

I am (herpey@openoffice.org) the author of OOoVirg, which is, as stated in some
replies, just a quick work around.
...
I am fully ok to contribute to OOo, and I will answer this to 
Sophie, but I may not have all the time I would have.

I am quite pleased to see some debate about this issue, and I am 
sure solutions will be found for short and long term.
Comment 1 andreschnabel 2003-09-26 12:41:38 UTC
Setting Target 1.1.1 as a "wish". Adding Sophie to cc.

Please have in ind, that the original issue is still the one with the
most votes.
Comment 2 maison.godard 2003-09-26 12:54:47 UTC
Adding myself to CC
Comment 3 ggabriel 2003-09-26 15:59:30 UTC
me too
Comment 4 vuillod 2003-09-26 16:03:17 UTC
*** This issue has been confirmed by popular vote. ***
Comment 5 vuillod 2003-09-26 16:07:26 UTC
Me too.

Fred
Comment 6 Martin Hollmichel 2003-09-26 16:15:15 UTC
do we need any debate on this issue. I feel know. What we need is a
patch we can apply tothe codeline or some artifacts fot the goodie bag.

who will volunteer to drive this issue ?
Comment 7 sgautier.ooo 2003-09-26 18:17:37 UTC
Hi Martin,
How could we do more to help ? I have contacted the owner of the pach,
he has changed the licence from GPL to LGPL/SISSL, he has signed the
JCA, he has volunteered to help. All this happened a long time ago
now, I've sent the pach with a copy to Kevin (if I remember well).
Last time I ask you about the pach (it was for rc4) you didn't answer
me. I'm still in contact with Remy Peyronnet. So please now tell me
what to do :
- invite Remy here or on the release list or on the sc list,
- if this pach has a chance to be in a release, what do you need for
it happen, 
- what about translation we have proposed to do,
I'm sorry, I'm not a developer, all I can do is to help things and
people to be connected. 
Best - Sophie
Comment 8 herpey 2003-09-29 21:28:33 UTC
Hello,

Happy to hear some news about this :-)

As mentionned, the materials to help to do the workaround are 
there : 
http://www.via.ecp.fr/~remi/win/ooovirg/ooovirg_integration.zip (as 
it was first aiming french people, the web page is not translated, 
but I will answer any question about this material)
I did not know much about the internal structure of OOo so I cannot 
do the real patch of integraion in OOo, but I am OK to help as much 
as I can, for a patch or the goodie bag.

Rémi
Comment 9 Martin Hollmichel 2003-10-27 17:59:21 UTC
I began to review the Windows code. I found dependency to mfc there.
until now we were successful to avoid this dependency.
Comment 10 khendricks 2003-11-12 12:46:42 UTC
Hi,

Ading myself to CC on this one.

I agree, a short term fix is needed before 1.1.1

BTW: one viable solution is to change the vcl code that handles key entry to not map 
keypad decimal to '.' for the non-unicode input on older WIN platforms, and for 
unicode input on newer WIN platforms, we can also use calls to lookup the raw 
keycode value and convert it to a keypad decimal if the raw key value for the keypad 
was generated.

My 2 cents,

Kevin
Comment 11 utomo99 2003-11-17 04:55:21 UTC
Added myself to CC. 

utomo > martin:
Dont forget to change to start when you already start this. 
Thanks
Comment 12 joerg.barfurth 2003-12-15 11:32:52 UTC
Please don't forget, that any fix to this should be configurable - and IMHO also
should not be the default behavior.

While a change in mapping of the decimal separator key might make sense for Calc
users, it may be very confusing for Writer users or computer newbies, if the
character they get is different from the one on the key.

Remapping in VCL has the problem that it can't easily be made configureable by
end users. Please keep the extensive discussions from #1820# in mind.
Comment 13 pbielen 2003-12-15 11:39:38 UTC
Why ??? It is default behaviour in Excel, and nobody
is complaining about that, because that IS the correct
behaviour to get a comma of the keypad.

Best Regards,

Patrick
Comment 14 lcn 2004-01-04 18:37:05 UTC
Language found in issuezilla affected by this problem : Afrikaans (to verify), 
Basque (to verify), Belgian, Catalan (to verify), Czech (to 
verify), Dutch, French (except Switzerland ?), Galician (to verify), Italian 
(to verify), Portuguese (to verify, Portugal), Serbian (to verify), Spanish, 
Slovak (to verify).

More language ?

But, in general, which languages are concerned ?
Comment 15 Martin Hollmichel 2004-01-09 14:03:42 UTC
does anybody make experiences with the Unix version of ooovirgx.c ? this is only
seg faulting in XGetKeyboardMaping on my Linux box. Also I think the "User
Interface" also needs some more "explaination".
Comment 16 drspock2k 2004-01-09 20:08:12 UTC
As I mentioned in issue #1820, I can assure that Catalan, Basque and Galician
are affected. Other languages has been verified in #1820 posts.

Àlex García.
Comment 17 pavel 2004-01-11 09:56:44 UTC
Martin,

ooovirgx works on SL 8.2 and also on SL 8.0:

pavel@oo:~> gcc -o ooovirgx ooovirgx.c -L/usr/X11R6/lib -lX11
/tmp/ccUUfL8L.o: In function `main':
/tmp/ccUUfL8L.o(.text+0x165): the `gets' function is dangerous and should not be
used.
pavel@oo:~> ./ooovirgx 
Hello world

XGetKeyboardMapping - count = 6 ; (Point is 46, Comma is 44) KeySim : 46, 0, 0,
0, 0, 0, 
Change the keyboard mapping...

XGetKeyboardMapping - count = 6 ; (Point is 46, Comma is 44) KeySim : 44, 0, 0,
0, 0, 0, 
(rc = 0) Try it ! : ...,,,,.,.,.,.,.,.,
Revert the keyboard mapping...

XGetKeyboardMapping - count = 6 ; (Point is 46, Comma is 44) KeySim : 46, 0, 0,
0, 0, 0, 
pavel@oo:~> ............

I always tried to combine dot and the dot on numeric keypad.
Comment 18 Martin Hollmichel 2004-01-11 10:33:46 UTC
mh->pavel: I took the ooovirgx.c from tools/cntrib/virgule/source/unx and tried
it on a SuSE 7.1, I will try on 9.0 now
Comment 19 herpey 2004-01-11 11:05:53 UTC
herpey->mh

I wrote ooovirgx.c on a debian woody. This is just a sample of utilisation of
mapping under X, I do not use it myself, as I use xmodmap. If there is some
problems with this code, maybe a direct call to xmodmap, or the re-use of the
xmodmap's code would be more portable ?

About the "User interface", as you pointed out, there is none for ooovirgx.c, as
nothing is to configure. For the windows version, the user interface was
designed to support many OOo / StarOffice version. If integrated, this user
interface needs to be re-thought.

Also, I strongly recommend the use of localhook.inc, less intrusive,
TrayIcon-free and MFC-free.
Comment 20 Martin Hollmichel 2004-01-15 13:28:27 UTC
mh->herpey: but localhook.inc needs integration in OOo code and configuration,
right ?
Comment 21 herpey 2004-01-15 20:29:22 UTC
herpey->mh : 

That's true. localhook.inc needs to be integrated somewhere in the startup of
OOo spreadsheet (by calling registerHook()). Also, a call to unregisterHook
would be better at the end of OOo, but not necessary for just a quickaround.

The configuration should be much more light, as just a check box "Use real
decimal separator dor numpad dot" is required (all the ooovirg's fields are
useless if it is properly integrated with localhook.inc).
Comment 22 Martin Hollmichel 2004-01-16 06:15:14 UTC
mh->nn: does this last comment of herpey sounds reasonable and doable ? 
I would prefer a solution without changing or adding any UI because the process
of post release UI changes has severe impact to all the l10n teams.

from that point of view I'd prefer the solution of the extra Trayhooktool.
Comment 23 niklas.nebel 2004-01-16 09:30:05 UTC
nn->mh: That's right. The need for a UI and configuration change is the main
obstacle that prevents us from doing the full solution (as proposed by bh in
issue 1820) for 1.1.1.

This issue is all about a short-term solution that doesn't require UI or
configuration changes, so an independent tool seems to be the only possibility.

Note that it's also not possible to call a registerHook function at startup of
Calc only, as all the OOo document types are in fact handled by a single
application.
Comment 24 herpey 2004-01-17 14:55:53 UTC
herpey->nn&mh:

I don't really get the point with the l10n problem : there is exaclty the same
problem using an external tool with UI, isn't it ?
Or maybe is it unacceptable to have a string untranslated in OOo, but if it is
presented as an external tool it's ok ?

->nn : about the startup, would be that possible to call registerHook when a
calc document is beeing displayed (something like OnFocus) and unregisterHook
when another document take the focus ?
Comment 25 Martin Hollmichel 2004-01-19 16:37:36 UTC
>Or maybe is it unacceptable to have a string untranslated in OOo, but if it is
presented as an external tool it's ok ?

not ok, but in some kind more acceptable than in the OOo application it self.

BTW: I'm missing a file afxres.h for the IconTray, so I'm not able to recompile
and to provide an English version. can you please check the archive ?
Comment 26 herpey 2004-01-19 22:22:29 UTC
True, afxres.h is missing... But it compiles with VS6 anyway. I did not create
any file of this kind, as you could guess, this is pure MFC... Ah found it :
C:\Program Files\Microsoft Visual Studio\VC98\MFC\Include

Well, I cannot agree about the second point... If UI is really the only point,
would an external tool modifying a configuration file be a solution ? Also, no
UI exists for the piece of code I wrote for xmodmap. Should a second external UI
be written ? Is l10n so huge a problem ? (I mean : this problem is really wanted
by a large number of l10n teams, so I think they could do just a little effort,
no ?)
Comment 27 Martin Hollmichel 2004-01-20 09:49:38 UTC
mh->herpey: thanks, I got the missing path in my msdev configuration, it
compiles fine now.

mh->dl: can you please assist in discussion, so that we come to a temporary
solution ASAP ?!
Comment 28 Martin Hollmichel 2004-01-26 09:29:50 UTC
committet to ooo111fix2
Comment 29 bigserpent 2004-01-30 16:50:03 UTC
It stil doesn't allow to select decimal separator independently from assumed by
OO local settings for some language.
Comment 30 andreschnabel 2004-01-30 17:36:01 UTC
andre->bigserpent:
Remember, that this is a temporary fix. The main porpose is to us the numeric
pad's dot /comma as decimal seperator (as used in OOo's local settings).

For a configurable solution please wait till OOo 2.0 and add your comments to
issue 1820 (but I don't think, there is something missing at this issue).
Comment 31 maison.godard 2004-02-08 09:42:42 UTC
Hi
tested on the new 1.1.1b
WinXP Home french

The fix doesn't seem to work :(

in celle A1, unsing keypad and typing 
1.1 which leads to a misformating as a date 01/01/2004

using legal comma on keyboard 1,1 --> ok recognized as number

did i miss something ?

Laurent
Comment 32 lcn 2004-02-09 19:16:45 UTC
Confirm laurentgodard comment.
Tested with English OOo 1.1.1b on French win2k.

And I didn't find any option for numpad dot.

Will work if is localized compiled ?

Should this issue be reopened ?
Comment 33 utomo99 2004-02-10 02:46:33 UTC
Reopen as 2 people confirm still have this problems. 
Comment 34 Martin Hollmichel 2004-02-17 15:04:07 UTC
setting issue to fixed as the tools are in the build and are verified by joost.

if there is need for a additional README/documentation, please file a new issue.
Comment 35 lcn 2004-03-08 18:15:31 UTC
Doesn't work in French OOo 1.1.1 rc 040303 fr on French win2k.
Downloaded from http://ftp.stardiv.de/pub/OpenOffice.org/contrib/rc/1.1.1rc/.
Don't know for ohters localizations.
Comment 36 herpey 2004-03-14 22:58:04 UTC
Hi,

I released a corrected version of OOoVirg, which fixes :
    *  Conflicts with software using other keyboard hooks (iTouch from Logitech,
Autocad,...) [Should work, but I cannot test : I have not such materials...]
    * Traybar icon too similar with the one of the Quick Launch of
OpenOffice.org (Thanks to Frédéric Vuillod)
    * A Win95 problem (DLL not found), caused by the long name of the DLL.

There is just a few lines modified in the code ; that would be nice if those
changes could be integrated (it is only bug fixes). Only one point could cause
problems in the integration : the use of #pragma data_seg("SHARED") (required by
the fix of conflicts)

The pack is here (code included) :
http://people.via.ecp.fr/~remi/win/ooovirg/ooovirg_tray.zip

Since I released this version, I haven't received complains, so it should work
decently :-)

-- 
Rémi Peyronnet
Comment 37 sgautier.ooo 2004-04-09 15:08:16 UTC
Hi, 
Here are some release notes to use OOoVirg under 1/1/1 release.
Kind regards - Sophie

OpenOfficeHookTray for Windows - Readme

===================================
WHAT IS OpenOfficeHookTray?

Some locale keyboard layouts (Ex: Dutch, French, Spanish...)
have a wrong decimal separator set on the NumPad (typically, a period '.'
 instead of a coma ",").
OpenOfficeHookTray remaps, at system runtime, the correct separator.

===================================
HOW TO RUN OpenOfficeHookTray?

The FIRST time you run OpenOfficeHookTray, you will need to follow
each of the following steps:

1. you will find OpenOfficeHookTray in the 'program' directory of
OOo's installation directory.
2. BEFORE OOo runs, double click on OpenOfficeHookTray.exe.
3. A tray icon appears called "Hook virgule OpenOffice".
4. Right click on this icon and choose "Show" inb the context menu.
5. The "OpenOffice Tray" dialog appears
6. Choose how you want to use OpenOfficeHookTray in the options.
We advice, for an easy use, to check "active for all windows", thus you will
avoid any typo in the name of the target application.
7. Click on the [Register] button. This will save your settings
8. Click on the [Quit] button. OpenOfficeHookTray will shut down.
9. Restart OpenOfficeHookTray.
10. Start OpenOffice. The NumPad now outputs a coma instead of period.

===================================
HOW TO START OpenOfficeHookTray AUTOMATICALLY?

The best way to start OpenOfficeHookTray automatically is to create a
link in the Startup menu:
1. In Windows Explorer, go to <OOo_installation_path>\program
2. Copy the OpenOfficeHookTray.exe file
3. Go to your Startup directory. The easiest way to do it is to
click on the [Start] button, then "Programs - Startup"
4. Right click on the opening sub menu.
5. Choose "Paste link here".

OpenOfficeHookTray will now be started on each Windows starup.

===================================
HOW TO (DE)ACTIVATE OpenOfficeHookTray?

If you need to suspend OpenOfficeHookTray's execution, right click on its tray
icon and choose "Deactivate"

If you need to go on running OpenOfficeHookTray's execution, right click on
its tray icon and choose "Activate".

===================================
CREDITS

Origin: OpenOffice.org Community (www.openoffice.org)
Program author: Rémi Peyronnet
Readme author: Éric Savary
Comment 38 sgautier.ooo 2004-04-09 15:11:49 UTC
Hi,

I'm reopening this issue in order to have the new release of OOoVirg included in
the 1.1.2 release (see the mail from Herpey on march 14 2004). Thanks (and sorry
if I'm wrong to reopen it). 
Kind regards - Sophie
Comment 39 sgautier.ooo 2004-04-09 15:14:12 UTC
Hi all,

In order to ease the use of OOoVirg under Windows, Laurent Godard has written a
macro that install the software in OOo.
The document is here (but in french).
http://qa.openoffice.org/issues/show_bug.cgi?id=27450

The pink button 'Installer OOoVirg' install the icon OOoVirg in the systray and
add an icon in the OOo function bar. When you click on this button, a dialog
window pop up, saying that the installation will be effective the next time
you'll run Windows and that the icon will be visible the next time you run OOo.
The 2 buttons Oui (Yes) and Non (No) in the dialog window allow you to run
OOoVirg immediatly if you answer Oui (Yes).

The button on the left of the document [Désactiver le lancement automatique]
uninstall OOoVirg, the second button on the right [Supprimer l'icône de
lancement rapide] remove the icon from the function bar in OOo.

Kind regards - Sophie 
Comment 40 Martin Hollmichel 2004-04-13 12:44:16 UTC
we should should reopen issue only in case that:
* a fix failed

if we want to do some additions, especially if we are targeting a new milestone,
we should open a new issue. this makes tracking of issues more easy. so I opened
new issue 27728 for this.
Comment 41 sgautier.ooo 2004-04-13 14:57:16 UTC
Hi Martin,

Thanks for you input, I'll remember it for the next time.
Kind regards - Sophie
Comment 42 Martin Hollmichel 2004-10-15 15:13:38 UTC
close issue.